From: Eli Zaretskii <eliz@gnu.org>
To: Tobias Bading <tbading@web.de>, Po Lu <luangruo@yahoo.com>
Cc: 63312@debbugs.gnu.org
Subject: bug#63312: 29.0.90; set-frame-parameter sometimes called with dead frame when quitting ediff
Date: Sat, 06 May 2023 13:34:41 +0300 [thread overview]
Message-ID: <833549hhoe.fsf@gnu.org> (raw)
In-Reply-To: <04798b34-f836-f889-88e7-2308229b5ff3@web.de> (message from Tobias Bading on Sat, 6 May 2023 12:10:33 +0200)
> Date: Sat, 6 May 2023 12:10:33 +0200
> Cc: 63312@debbugs.gnu.org
> From: Tobias Bading <tbading@web.de>
>
> > Does the patch below give good results?
> >
> > diff --git a/lisp/x-dnd.el b/lisp/x-dnd.el
> > index 9286a18..acfbbed 100644
> > --- a/lisp/x-dnd.el
> > +++ b/lisp/x-dnd.el
> > @@ -609,8 +609,9 @@ x-dnd-init-xdnd-for-frame
> > (defun x-dnd-after-move-frame (frame)
> > "Handle FRAME moving to a different position.
> > Clear any cached root window position."
> > - (set-frame-parameter frame 'dnd-root-window-position
> > - nil))
> > + (and (frame-live-p frame)
> > + (set-frame-parameter frame 'dnd-root-window-position
> > + nil)))
> >
> > (add-hook 'move-frame-functions #'x-dnd-after-move-frame)
>
> It probably would, because for testing purposes I already patched
> handle-move-frame like this:
Not really, because there could be other functions on the hook
variable, which do deal well with a dead frame.
Po Lu, any objections to installing my proposed change?
next prev parent reply other threads:[~2023-05-06 10:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 17:02 bug#63312: 29.0.90; set-frame-parameter sometimes called with dead frame when quitting ediff Tobias Bading
2023-05-05 17:50 ` Eli Zaretskii
2023-05-06 7:27 ` Tobias Bading
2023-05-06 9:42 ` Eli Zaretskii
2023-05-06 10:10 ` Tobias Bading
2023-05-06 10:34 ` Eli Zaretskii [this message]
2023-05-06 11:12 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-06 11:17 ` Eli Zaretskii
2023-05-06 12:01 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=833549hhoe.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=63312@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
--cc=tbading@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).