From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63744: 28.2; fix dired-guess-default Date: Tue, 30 May 2023 05:36:11 +0300 Message-ID: <83353eh7fo.fsf@gnu.org> References: <838rdajmkk.fsf@gnu.org> <83jzwthsx5.fsf@gnu.org> <87fs7g53rx.fsf@web.de> <83sfbfgx2v.fsf@gnu.org> <834jnvgfh2.fsf@gnu.org> <87pm6i4qfa.fsf@web.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19267"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63744@debbugs.gnu.org, sdl.web@gmail.com To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 30 04:36:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q3pDm-0004oI-9J for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 May 2023 04:36:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3pDQ-0007fj-5u; Mon, 29 May 2023 22:36:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3pDO-0007fX-Rt for bug-gnu-emacs@gnu.org; Mon, 29 May 2023 22:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q3pDO-0003Ts-JN for bug-gnu-emacs@gnu.org; Mon, 29 May 2023 22:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q3pDN-0000n5-WB for bug-gnu-emacs@gnu.org; Mon, 29 May 2023 22:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 May 2023 02:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63744 X-GNU-PR-Package: emacs Original-Received: via spool by 63744-submit@debbugs.gnu.org id=B63744.16854141393004 (code B ref 63744); Tue, 30 May 2023 02:36:01 +0000 Original-Received: (at 63744) by debbugs.gnu.org; 30 May 2023 02:35:39 +0000 Original-Received: from localhost ([127.0.0.1]:59522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3pD0-0000mO-Pn for submit@debbugs.gnu.org; Mon, 29 May 2023 22:35:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3pCz-0000m9-Bs for 63744@debbugs.gnu.org; Mon, 29 May 2023 22:35:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3pCt-0003Hy-Qw; Mon, 29 May 2023 22:35:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=m5BfSZgpJ0w/UVAxi6L6tr9NNOieCOuxk1uNBndVl1A=; b=cd6PS2Ku642B WEyQlZs84NMJY1vaPj90Fi9AlNJSGndS5mvFgqPTJJs9u0PwN8/oQRJ3chinlZHLZU1ERWnlaVf00 lonstqAB2zLM1N6MVW6+h0x+RcniWRgs1DfFJuBAWryNCL0sjhUu6Yo1IWOuIY4ZyWuU/phuBiyi1 GNVjDIOr15Arb2YVEQYWoyJvTftYMajdNdzhXjClSqn8LmD2v9vFBn2XvNiQ80jaRb51bIPRbvNxH 8+WSkIvY+jFAtyBys/+FzY1wVfCU/Cv9YTfV9eZihKePghGeN3EcC6VzrPnxV+Co+6gQqklatq32X Mn0qKIG39NxkRT33jD9bGw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3pCt-0004QD-7p; Mon, 29 May 2023 22:35:31 -0400 In-Reply-To: <87pm6i4qfa.fsf@web.de> (message from Michael Heerdegen on Tue, 30 May 2023 02:24:25 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262616 Archived-At: > From: Michael Heerdegen > Cc: Leo Liu , 63744@debbugs.gnu.org > Date: Tue, 30 May 2023 02:24:25 +0200 > > then you meant to recompute the variable's value every time the user wants > to open a file with dired? No, every time the situation changes in a way that requires its recomputation. I don't have a clear idea when that happens, but if the REGEXP part is ".", it is clear to me it happens quite often already, since the list of commands for a given file depends on the file, and "." does not. > It's a defcustom so Emacs should not change the value at all. We are talking about user customizations. A user can make his/her customizations change the value as often as needed. > And recomputing the whole value every time is much slower than computing > a list of defaults for one class of files matched by the regexp. That is not Leo's use case, AFAICT: the list of commands is dynamically recomputed when needed anyway. > The conditions that need to be checked are very different for > different file types in a typical scenario, and the suggested design > is more efficient: first look at the file type by matching the RE > part, then decide, at the moment of user request, what applications > are appropriate for this type of file (and only for this type) in > this moment. Like I said: I'm not against extending the value to support this, I just don't see how this could be considered an urgent bugfix that must be done in Emacs 29, that's all.