From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64242: [PATCH] Fix VC package build when there is no docs dir Date: Fri, 23 Jun 2023 09:02:47 +0300 Message-ID: <83352i3ed4.fsf@gnu.org> References: <877cruvijk.fsf@dsemy.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27109"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64242@debbugs.gnu.org To: Daniel Semyonov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 23 08:03:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qCZtG-0006pJ-Ga for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Jun 2023 08:03:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qCZsw-0005Ea-FI; Fri, 23 Jun 2023 02:03:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCZss-0005Cu-Jk for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2023 02:03:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qCZss-0007Uq-8C for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2023 02:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qCZsr-0005w4-Ub for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2023 02:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Jun 2023 06:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64242 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64242-submit@debbugs.gnu.org id=B64242.168750016222792 (code B ref 64242); Fri, 23 Jun 2023 06:03:01 +0000 Original-Received: (at 64242) by debbugs.gnu.org; 23 Jun 2023 06:02:42 +0000 Original-Received: from localhost ([127.0.0.1]:37250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCZsY-0005vX-Ia for submit@debbugs.gnu.org; Fri, 23 Jun 2023 02:02:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCZsW-0005vI-Bq for 64242@debbugs.gnu.org; Fri, 23 Jun 2023 02:02:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCZsR-0007RN-4O; Fri, 23 Jun 2023 02:02:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=llYkTpd7KTTue1+SiBOYVPNYK7kE6v8x0cDb08ZiJO0=; b=aPHKi6SYbyhE qQ0I/IBZD+nc7NhMxkGE838NDSf8kpnBH1kmro6RgQpeRjXJkDLTfQFjiBcqKuiab5m471PdbAtRM +2R4Wuh0svhpHViDjqDOnhB9rTH7HYuZl4R1k4BQo0/NFnqDvrnIDg5P2um5kqmoc2ggFzc3qtibV bDxcgZxwjEUOHWx535Pb8IRefz8QS6QHJyctxfDXbByf+sYF5OuP6aM77bykX7EfE5m8sho3v/NrD Sh1NGG6flaggH24U6zoq7qBhLPJ8jtaNPWyUgIuqP3IplUK3A+oFAXRzY5pMBD4qGQ+cf6riTltzf W1DYBx7JWo8n+O2YLW9J+w==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCZsQ-0002uJ-FB; Fri, 23 Jun 2023 02:02:34 -0400 In-Reply-To: <877cruvijk.fsf@dsemy.com> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263931 Archived-At: > Date: Fri, 23 Jun 2023 08:45:03 +0300 > From: Daniel Semyonov via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > This fixes a small mistake introduced recently in > 'package-vc--build-documentation' which causes it to error out when its > 'file' argument isn't a directory. What do you mean by "isn't a directory"? FILE is supposed to be a documentation file, not a directory, see the doc string of this function. Do you mean that FILE is a relative file name so that file-name-directory returns nil for it? If so, I think the correct fix would be to reverse the order: (docs-directory (file-name-directory (expand-file-name file))) Can you show a recipe to reproduce this problem, preferably starting from "emacs -Q"? And finally, this issue exists on the emacs-29 release branch as well, doesn't it? Thanks.