unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Semyonov <daniel@dsemy.com>
Cc: 64242@debbugs.gnu.org
Subject: bug#64242: [PATCH] Fix VC package build when there is no docs dir
Date: Fri, 23 Jun 2023 09:02:47 +0300	[thread overview]
Message-ID: <83352i3ed4.fsf@gnu.org> (raw)
In-Reply-To: <877cruvijk.fsf@dsemy.com> (bug-gnu-emacs@gnu.org)

> Date: Fri, 23 Jun 2023 08:45:03 +0300
> From:  Daniel Semyonov via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> This fixes a small mistake introduced recently in
> 'package-vc--build-documentation' which causes it to error out when its
> 'file' argument isn't a directory.

What do you mean by "isn't a directory"?  FILE is supposed to be a
documentation file, not a directory, see the doc string of this
function.  Do you mean that FILE is a relative file name so that
file-name-directory returns nil for it?  If so, I think the correct
fix would be to reverse the order:

  (docs-directory (file-name-directory (expand-file-name file)))

Can you show a recipe to reproduce this problem, preferably starting
from "emacs -Q"?

And finally, this issue exists on the emacs-29 release branch as well,
doesn't it?

Thanks.





  reply	other threads:[~2023-06-23  6:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-23  5:45 bug#64242: [PATCH] Fix VC package build when there is no docs dir Daniel Semyonov via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-23  6:02 ` Eli Zaretskii [this message]
2023-06-23  6:32   ` Daniel Semyonov via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-23  7:10     ` Eli Zaretskii
2023-06-23  7:35       ` Philip Kaludercic
2023-06-24 10:24         ` Philip Kaludercic
2023-06-24 10:43           ` Eli Zaretskii
2023-06-24 15:34             ` Philip Kaludercic
2023-06-24 17:07               ` Eli Zaretskii
2023-06-25 21:41                 ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83352i3ed4.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=64242@debbugs.gnu.org \
    --cc=daniel@dsemy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).