From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64046: 30.0.50; Quoting in customize choice tags Date: Sat, 24 Jun 2023 09:37:34 +0300 Message-ID: <83352h1i35.fsf@gnu.org> References: <87v8frihny.fsf@gmx.net> <837cs7we2z.fsf@gnu.org> <47e13491-1654-db22-2f8b-f12195953232@gmail.com> <87o7lhrm2x.fsf@gmx.net> <87edm3tg57.fsf@gmx.net> <613827fd-46e8-b8e8-dd91-1539f007a099@gmail.com> <878rc9rfef.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15756"; mail-complaints-to="usenet@ciao.gmane.io" Cc: maurooaranda@gmail.com, monnier@iro.umontreal.ca, 64046@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 24 08:38:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qCwua-0003rk-GR for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Jun 2023 08:38:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qCwuL-0004fv-Kh; Sat, 24 Jun 2023 02:38:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCwuJ-0004fn-0i for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 02:38:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qCwuI-00085t-OE for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 02:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qCwuI-0002Ax-30 for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 02:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Jun 2023 06:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64046 X-GNU-PR-Package: emacs Original-Received: via spool by 64046-submit@debbugs.gnu.org id=B64046.16875886508312 (code B ref 64046); Sat, 24 Jun 2023 06:38:02 +0000 Original-Received: (at 64046) by debbugs.gnu.org; 24 Jun 2023 06:37:30 +0000 Original-Received: from localhost ([127.0.0.1]:39869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCwtm-0002A0-9E for submit@debbugs.gnu.org; Sat, 24 Jun 2023 02:37:30 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCwth-00029k-Ki for 64046@debbugs.gnu.org; Sat, 24 Jun 2023 02:37:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCwtb-00082x-Dc; Sat, 24 Jun 2023 02:37:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=u4NK6EOiA91gfieGgrZF2MCLguhp7tmTzPsGqBkBamA=; b=ZoEKdqKCyNofK/tIlEYy PFSNioZnS9toKokdB3fpgK0Np3tHyfwiI3kwuWr9b2sz3sGX7ZjsA0MbU4YO8j6LT2dIqxLsGVLrd 3x+5YY51pUm4weBle1Q75vA6sJQriZzAXScbYc+DIZ5FXmMcac7wQwNMgaLUX5mWEVPTNGQihNdSU JCxe25qp/U+7IKHoz47W0o85LozjOAmOR9Yw97xXmyVEaHhIEgIbBdokm7qW4jPZ8Fud5ZGFX3pYz EsW2MLXofGIzbl1OQDwX5qY2a9zHhErwQkVBI+MXaWPkBn+5oWB1lQIbBq+lswMoQqOhEpuryfqiB tAZ+Ll2V8ehd/Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCwta-00069M-6Q; Sat, 24 Jun 2023 02:37:19 -0400 In-Reply-To: <878rc9rfef.fsf@gmx.net> (message from Stephen Berman on Sat, 24 Jun 2023 00:18:48 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263975 Archived-At: > From: Stephen Berman > Cc: 64046@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier > > Date: Sat, 24 Jun 2023 00:18:48 +0200 > > On Thu, 22 Jun 2023 19:59:26 -0300 Mauro Aranda wrote: > > > Stephen Berman writes: > > > >>> Thanks for the feedback.  You're right, that patch is too superficial; > >>> it also fails to do substitution in popup extended menus like the one > >>> produced by clicking the "State" button, with the result that in the > >>> item "Revert This Session's Customization" the apostrophe is not > >>> displayed in the "curve" style.  So I revised the patch, attached below, > >>> to iterate over the elements of each item in ITEMS, and it now appears > >>> to handle substitution with the "State" button display correctly, both > >>> as popup menu and as text menu buffer.  The latter is the result of > >>> applying widget--simplify-menu, if I debugged correctly, so I think this > >>> answers your concerns (though the text menu buffer already shows the > >>> substitution independently of my patch, due to commit bd3b426ebb).  Or > >>> have I misunderstood your concerns about widget--simplify-menu?  If so, > >>> can you give an example where the new patch fails? > >> > >> Just pinging in case this fell under the radar.  If there's no response, > >> what's the next step forward? > >> > >> Steve Berman > > > > It did, thanks for the ping. > > > > Since there's no problem with widget--simplify-menu, the patch looks > > good to me. > > Thanks. So Eli, should this go into master, since it's not a > regression, or is it ok to install this to the release branch? It does > seem pretty safe, since it's only applying substitute-command-keys in a > few more places in widget-choose. Pleased install on master. The problem is very minor and we have lived with it for many years, so it can wait a bit more. Thanks.