From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64428: [PATCH] Fix flymake mode line scrolling with pixel-scroll-precision-mode Date: Thu, 06 Jul 2023 17:04:39 +0300 Message-ID: <833521i1ag.fsf@gnu.org> References: <87zg4eq8xn.fsf@catern.com> <83ilaxij8c.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15306"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@catern.com, 64428@debbugs.gnu.org To: Spencer Baugh , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 06 16:05:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHPbv-0003ik-3m for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jul 2023 16:05:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHPbU-00027c-UQ; Thu, 06 Jul 2023 10:05:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHPbS-00026p-Ud for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2023 10:05:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qHPbS-0007aN-Kr for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2023 10:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qHPbS-0001G5-1P for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2023 10:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Jul 2023 14:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64428 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64428-submit@debbugs.gnu.org id=B64428.16886522994826 (code B ref 64428); Thu, 06 Jul 2023 14:05:02 +0000 Original-Received: (at 64428) by debbugs.gnu.org; 6 Jul 2023 14:04:59 +0000 Original-Received: from localhost ([127.0.0.1]:41659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHPbL-0001Fi-RC for submit@debbugs.gnu.org; Thu, 06 Jul 2023 10:04:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHPbH-0001FQ-Ih for 64428@debbugs.gnu.org; Thu, 06 Jul 2023 10:04:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHPb5-0007V5-Tj; Thu, 06 Jul 2023 10:04:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=s+TfYpOFTqyzdnt5qTUGTAWvZIk9QI0WpvWE8rzQ/bs=; b=dVoXXilvDMFnLASmqBkw 2Gl9CEit3mm+/toyr8if4R2RYTitJWBZ6wJF87KH8HtBjHwgHBOxWEqoHGEhLzHvE/1FrBnSGamuJ 7SpszMvxhoT5PBENSw3ZSiaAReA2rWrt2iPQhYvdgJQkwMpWqKN1Dpqk6/LAwMQYLRN6aKLjt4j77 BhhupisB6xkvkKfjzCuHI1kvuuy3Sk2dlSLz6++aljIqlSS2D+9OiHqtysMmNTRCdVxmKjUgYP2vO s1Eay1c+XzMM7pSWrNl0ayqMvfjmiTXAIMCx4XcnL3Qz6oUcEGlm+0qBFnP1HHlxmTyk9twJ22M5m jFrFt9a1jiONeA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHPb5-0001iu-Dr; Thu, 06 Jul 2023 10:04:39 -0400 In-Reply-To: (message from Spencer Baugh on Thu, 06 Jul 2023 09:16:41 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264680 Archived-At: > From: Spencer Baugh > Cc: sbaugh@catern.com, 64428@debbugs.gnu.org > Date: Thu, 06 Jul 2023 09:16:41 -0400 > > Eli Zaretskii writes: > > >> * lisp/progmodes/flymake.el:(flymake--mode-line-counter-scroll-prev, > >> flymake--mode-line-counter-scroll-next, > >> flymake--mode-line-counter-map): Add. > >> (flymake--mode-line-counter): Use new keymap and include 'type as a > >> property in the mode-line. > > > > Thanks. Any reason you couldn't simply add more events to the > > existing code? > > Two reasons: > > 1. I initially did that but it made the code uglier. Also, this code is > run every time the mode-line is updated, and adding more of that seems > bad. > > 2. This makes describe-key work better and makes it possible for users > to configure the scroll direction or add more bindings for different > things. This means your changeset is actually two different loosely-related changes. The one that refactors the original code needs approval from Joćo (CC'ed). Once Joćo is happy with that refactoring, I'm okay with adding the extra events to it.