From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced Date: Sat, 15 Jul 2023 10:46:30 +0300 Message-ID: <83351pehwp.fsf@gnu.org> References: <87o7ri74qv.fsf@localhost> <7ccb0e8131f84ca2ea0f0c0aed11dc197b578a64.camel@laposte.net> <83o7l61lz6.fsf@gnu.org> <2aa76ba11fd0a77ba107@heytings.org> <30832e86470f7dc33387@heytings.org> <83r0pyw89y.fsf@gnu.org> <215b00d2590a10728db4@heytings.org> <83sfa7puzb.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9262"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60467@debbugs.gnu.org, frederic.giquel@laposte.net, yantar92@posteo.net, monnier@iro.umontreal.ca, acm@muc.de To: gregory@heytings.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 15 09:47:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKZzo-0002BB-Gw for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jul 2023 09:47:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKZzg-0005HB-Az; Sat, 15 Jul 2023 03:47:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKZza-0005GQ-1B for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 03:47:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKZzZ-0006eR-QB for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 03:47:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKZzZ-0001QO-MJ for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 03:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jul 2023 07:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60467 X-GNU-PR-Package: emacs Original-Received: via spool by 60467-submit@debbugs.gnu.org id=B60467.16894071895403 (code B ref 60467); Sat, 15 Jul 2023 07:47:01 +0000 Original-Received: (at 60467) by debbugs.gnu.org; 15 Jul 2023 07:46:29 +0000 Original-Received: from localhost ([127.0.0.1]:43987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKZz2-0001P5-Re for submit@debbugs.gnu.org; Sat, 15 Jul 2023 03:46:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKZz0-0001Or-Pv for 60467@debbugs.gnu.org; Sat, 15 Jul 2023 03:46:27 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKZyl-0006XT-52; Sat, 15 Jul 2023 03:46:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9ybx8MNh60+ooNC6FrXfOSAXaV7RwwFzJ3gcqLLPw6E=; b=qdjWsYjeVniW jCpzldV+URp+iBCIENxjXEzQ9GAfEpgixExfaZ4+fE5yMVmPk2t2L1mb1KYWzEohUb5z03aQ+gd7U l4U0NuQez4dDLZd2wauBYvlPcGgsbjCTJX91/Z/eW261mLH8OiI2mcTZzk8q0XlhcvGi8Rj36QZoQ L2mXagKhgG3dwhC7KYcBBfto9biP20A80EoUJwxbH82xc7/M7dKAQB8SWIPprtqEW51wgG7+TIon6 20ktUuXafwToFe4KN21pj0T/g2mvmz6lf5MwA1ImOTVgmZ95V03OXQwaUNmHQ1NuL6KgYSXLtog8O k5np+ExxL6XdOl+6uweYkg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKZyj-00026T-QW; Sat, 15 Jul 2023 03:46:10 -0400 In-Reply-To: <83sfa7puzb.fsf@gnu.org> (message from Eli Zaretskii on Sat, 01 Jul 2023 17:27:52 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265157 Archived-At: Ping! > Cc: 60467@debbugs.gnu.org, frederic.giquel@laposte.net, yantar92@posteo.net, > monnier@iro.umontreal.ca, acm@muc.de > Date: Sat, 01 Jul 2023 17:27:52 +0300 > From: Eli Zaretskii > > > Date: Sat, 01 Jul 2023 14:14:11 +0000 > > From: Gregory Heytings > > cc: 60467@debbugs.gnu.org, frederic.giquel@laposte.net, yantar92@posteo.net, > > monnier@iro.umontreal.ca, acm@muc.de > > > > > > >> Well, that bug was already discussed at length six months ago, and the > > >> minimal change that was in the end installed (59c3c53efa) introduced a > > >> new bug. Should we design another minimal change, at the risk of > > >> introducing another bug? ISTM that the safe thing to do is the > > >> refactoring that was suggested. > > > > > > If there's no safer way than the refactoring suggested back then, we > > > will have to stay with this regression in Emacs 29.1 and install a > > > better fix only on master. After all, the fact that buffer-modified-p > > > is not undone is a minor inconvenience at best. > > > > > > > Indeed. A safer way probably exists, but I would not dare writing that > > patch. I believe Stefan is in a better position to write it. > > How about installing your patch, which you proposed back then, on > master, then? > > > >