From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65030: 30.0.50; Check keyword args of make-process Date: Tue, 08 Aug 2023 15:16:51 +0300 Message-ID: <83350tohjg.fsf@gnu.org> References: <83a5v5u9nf.fsf@gnu.org> <83o7jkrcme.fsf@gnu.org> <87sf8tapbf.fsf@gmail.com> <0E5BAD91-FE2A-4622-9F76-26E8CEB8F71A@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11682"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, 65030@debbugs.gnu.org, eller.helmut@gmail.com, monnier@iro.umontreal.ca To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 08 14:17:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qTLeT-0002qW-JQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Aug 2023 14:17:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qTLe9-0006hw-Rs; Tue, 08 Aug 2023 08:17:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTLe2-0006hH-TN for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2023 08:17:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qTLe2-0006Ol-LR for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2023 08:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qTLe2-00041F-AL for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2023 08:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Aug 2023 12:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65030 X-GNU-PR-Package: emacs Original-Received: via spool by 65030-submit@debbugs.gnu.org id=B65030.169149700015405 (code B ref 65030); Tue, 08 Aug 2023 12:17:02 +0000 Original-Received: (at 65030) by debbugs.gnu.org; 8 Aug 2023 12:16:40 +0000 Original-Received: from localhost ([127.0.0.1]:35404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTLdf-00040P-NY for submit@debbugs.gnu.org; Tue, 08 Aug 2023 08:16:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTLdd-000407-Rm for 65030@debbugs.gnu.org; Tue, 08 Aug 2023 08:16:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTLdX-0006HO-LY; Tue, 08 Aug 2023 08:16:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=tzMM1wx6EW4XL+lzuRa0IIjK8/6xWFi5nULUJOiC5eM=; b=BEldVfsHdTLzzeQS9HRW G+rspIpYCWFfAGNWOr6T81yTSFu3mG9dHNw/L7G+bdv2z6z7cKWkhbGzO83583fQpMdsHp5SYeYCV xwqAZDRMCT74r9nNDgcEsCB/NVwjqm6jfmAXJtou8VFkv0ei2RpCZVww/sybpHdwiyMTGAPYSaMeK Wb5v8xsBeASA4Hvh6U+3EbFbRJp2qUwsz27AX3QgqTBYIFaEDQWo0INPWH/zFBnfeyO7ce682vlrs 6kjqF2rxV34TGtR9ZULzsSe8r0CYbZ0TK7DNDAOraKgY71Opyr3biRMmnVE1OIP5FSPITebeVZilX CDSRB1jEnWM+OA==; In-Reply-To: <0E5BAD91-FE2A-4622-9F76-26E8CEB8F71A@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Tue, 8 Aug 2023 11:16:07 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266941 Archived-At: > From: Mattias Engdegård > Date: Tue, 8 Aug 2023 11:16:07 +0200 > Cc: Eli Zaretskii , Stefan Monnier , > eller.helmut@gmail.com, 65030@debbugs.gnu.org > > > Mattias> The main objection is that `make-process`, due to its design, is often > > Mattias> called indirectly using `apply` which would not trigger the > > Mattias> application of this compiler macro, so perhaps we should improve the > > Mattias> error handling of Fmake_process instead. > > > > As long as that improvement results in warnings for mistakes such as > > misspelled keywords, rather than errors. > > Of course not. Incorrect arguments detected at run-time should elicit errors, as they do now. > The point being that for something as complex as make-process they should be more helpful than just `wrong-type-argument`. Misspelled arguments to make-process don't elicit errors as of now, do they?