From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65509: [PATCH] Use correct env var when opening frames with freedesktop menu entries Date: Sat, 02 Sep 2023 19:58:57 +0300 Message-ID: <8334zwa4vi.fsf@gnu.org> References: <87ttsomgb5.fsf@mssdvd.com> <83msy7eesk.fsf@gnu.org> <87pm33sazt.fsf@yahoo.com> <835y4tbtpj.fsf@gnu.org> <87pm303499.fsf@mssdvd.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37795"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, stefankangas@gmail.com, 65509@debbugs.gnu.org To: Davide Masserut Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 02 19:00:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcTyn-0009h2-UE for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Sep 2023 19:00:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcTyU-00026l-Qw; Sat, 02 Sep 2023 12:59:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcTyT-0001vt-3J for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 12:59:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcTyS-0006Va-Pn for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 12:59:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcTyc-0004vk-J3 for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 13:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Sep 2023 17:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65509 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65509-submit@debbugs.gnu.org id=B65509.169367396818878 (code B ref 65509); Sat, 02 Sep 2023 17:00:02 +0000 Original-Received: (at 65509) by debbugs.gnu.org; 2 Sep 2023 16:59:28 +0000 Original-Received: from localhost ([127.0.0.1]:38514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcTy3-0004uQ-VD for submit@debbugs.gnu.org; Sat, 02 Sep 2023 12:59:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcTy1-0004u8-Jk for 65509@debbugs.gnu.org; Sat, 02 Sep 2023 12:59:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcTxl-0005mG-WB; Sat, 02 Sep 2023 12:59:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DqEp4ySByk1es4E7r4YxF/7yC/1LHX6jd0jV4cwIV9U=; b=AjW0bH55EbW5 C/INyw1bsXONvCCCfxVBorzcCGfZVgPRwSRqiaZKIIe9f9UmjdpqjFmD8vWX268NAW08apN7NAnpp lG5cMfq8lzEc5gwX98BZlOryBm7o5MNIrZ4qPkFMR3uJbkpGNsp46LwR8xKsIeSboUmvVZ7+NKP+5 8Wt3+xG0lF0/L1gc94hkTDEIpuncPd220qGkj/jlxxzkKC6e7MTMnMKNDN1LyIRGQ2IrT9Ngl4AfQ r6jUEMLJmi8lK2zv4qr0qFg26P3PLNxoDzc3mf9f3rEIZmcM2pGv0SG9xehbUMVmILf+h9GH0t4fD B/YUMmVnFYckyU1K+DF/sA==; In-Reply-To: <87pm303499.fsf@mssdvd.com> (message from Davide Masserut on Sat, 02 Sep 2023 18:24:43 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269031 Archived-At: > From: Davide Masserut > Cc: Stefan Kangas , luangruo@yahoo.com, > 65509@debbugs.gnu.org > Date: Sat, 02 Sep 2023 18:24:43 +0200 > > Eli Zaretskii writes: > > >> Po Lu writes: > >> > >> > I think this is the fix for the bug I couldn't reproduce > >> > earlier, bug#64310. The patch seems appropriate, thanks. > >> > >> >From the previous discussion, it seems like we wanted to get > >> >this fixed on emacs-29? > >> > >> Eli, WDYT? > > > > I don't know enough about these Freedesktop shortcuts to have an > > opinion. If this is installed only for the PGTK build, and you > > think > > it solves the problem, feel free to install on emacs-29. > > For the same reason that the current emacsclient.desktop doesn't > work with Wayland, installing the patch would break PGTK builds > under Xorg because they would look for an environment variable > that is not set by Xorg DEs. Sorry, I've just noticed it. Can you describe the issue in more detail? In particular, would it work to try several variables one after another?