From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] Date: Sun, 10 Sep 2023 19:57:41 +0300 Message-ID: <8334zmrmnu.fsf@gnu.org> References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83h6o84yz1.fsf@gnu.org> <875y4oaban.fsf@whxvd.name> <83bkeg4o1u.fsf@gnu.org> <87o7ifu2v8.fsf@localhost> <838r9j339x.fsf@gnu.org> <87tts78lve.fsf@whxvd.name> <87zg1u0yrp.fsf@whxvd.name> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35404"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yantar92@posteo.net, 65734@debbugs.gnu.org To: Sebastian Miele Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 10 18:59:07 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfNm6-0008xb-Fn for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Sep 2023 18:59:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfNm1-0003rb-51; Sun, 10 Sep 2023 12:59:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfNm0-0003rS-3e for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 12:59:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfNlz-0000ss-SD for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 12:58:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qfNm2-00015n-Ck for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2023 12:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Sep 2023 16:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65734 X-GNU-PR-Package: emacs Original-Received: via spool by 65734-submit@debbugs.gnu.org id=B65734.16943650984138 (code B ref 65734); Sun, 10 Sep 2023 16:59:02 +0000 Original-Received: (at 65734) by debbugs.gnu.org; 10 Sep 2023 16:58:18 +0000 Original-Received: from localhost ([127.0.0.1]:51183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfNlJ-00014g-Lf for submit@debbugs.gnu.org; Sun, 10 Sep 2023 12:58:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfNlE-00014M-VA for 65734@debbugs.gnu.org; Sun, 10 Sep 2023 12:58:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfNl4-0000oS-EK; Sun, 10 Sep 2023 12:58:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YbWoJIePe6RXZHAOS1eeOp0v+q1jH6Dt43ECLdOFtx4=; b=rIp4TjR9T/tx Z5By8N/BzjRFAoADM0ubkB6vX5Iwi8FqKXD++BM9uHKOo0y6HV5x7SUYWHM0xBeQ7ROtKIr5i7e/0 Bym8+ANCW1mfJ/EvHGnd/9Hi5Fyv3ICZjcl+U8nm1yTRuJMsfNoQtuxbOj6uoVLgVFlBeNson+PbN QkMhD2flfWRnsKxhVFepGIcbTMJaf6GqlP17vGFzZlFlRSeErHFuj3k0NQ2l79nFgF522uYUPHqDW WOBKC32gBbYpGJJXykUTxTnVWTVz00mpVmXtKb+aHvITSf07CN4g5PhpniXJN8mQVbHXqoE0H1NvD Ea7JH7hXISdWtTOh2ozK4g==; In-Reply-To: <87zg1u0yrp.fsf@whxvd.name> (message from Sebastian Miele on Sun, 10 Sep 2023 18:31:20 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269981 Archived-At: > From: Sebastian Miele > Cc: Eli Zaretskii , Ihor Radchenko > Date: Sun, 10 Sep 2023 18:31:20 +0200 > > I removed emacs-orgmode@gnu.org from CC. > > > From: Sebastian Miele > > Date: Wed, 2023-09-06 15:30 +0200 > > > > I will write the tests. And I will probably come up with an updated > > version of the original patch. There is at least one cosmetic change. > > And something else that I want to have tried. May take some time. > > Please have a look at the following patch. For now it contains three > tests, two of them with :expected-result :failed. (They do not fail on > the bug-fixed version of `kill-whole-line'.) Yes, there should be more tests, ideally: there are situations where kill-whole-line signals an error, and I don't think I see tests where some of the text is invisible (as the function uses forward-visible-line and end-of-visual-line). > There probably will be more tests and further questions. But for now, I > would like to basically have a statement of whether the style of writing > the tests goes in an acceptable direction. Looks reasonable, but I'm not sure I understand what will the test show if one of the tests fails: will the information shown then tell enough to understand which of the sub-tests failed and why? Thanks.