From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work Date: Sat, 21 Oct 2023 13:57:21 +0300 Message-ID: <8334y4s0oe.fsf@gnu.org> References: <1d9187b71e7288eaf08ac9a2f0559bdf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28579"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66655@debbugs.gnu.org To: tomasralph2000@gmail.com, Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 21 12:58:53 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qu9gx-0007E6-G3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Oct 2023 12:58:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qu9gh-0001Jw-Q9; Sat, 21 Oct 2023 06:58:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qu9gg-0001Jg-8e for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 06:58:34 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qu9gf-00010N-Uh for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 06:58:34 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qu9h7-0004Pt-Kc for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 06:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2023 10:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66655 X-GNU-PR-Package: emacs Original-Received: via spool by 66655-submit@debbugs.gnu.org id=B66655.169788588216897 (code B ref 66655); Sat, 21 Oct 2023 10:59:01 +0000 Original-Received: (at 66655) by debbugs.gnu.org; 21 Oct 2023 10:58:02 +0000 Original-Received: from localhost ([127.0.0.1]:42342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu9g9-0004OT-T3 for submit@debbugs.gnu.org; Sat, 21 Oct 2023 06:58:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu9g6-0004Nt-Ru for 66655@debbugs.gnu.org; Sat, 21 Oct 2023 06:58:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qu9fZ-0000cW-3H; Sat, 21 Oct 2023 06:57:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=A5WzKj08jqJ0Qm4n32y6QADtfVNSzoGj0TOG/mbGVIU=; b=Kh5vCGpoKjTv 08xQ9fYsmvRkyqKaFU2/P1HMN01rjiNdYv/3LPkBGMDSmjvgzEGjzBB5ua6Tvw+f2/LqPUxKMK8c4 RnsrArogMYmE7GnCbnaXt7r1aDs5JAdS6cEqJiWUHBz3/NYxpBMG4/rHXRTzu/Hcx6k7wqrRsDyD7 gdmZfeJtYhWapZ8F5Z5iWbpZERI4x859GTcUTRSV0ybo7Y7MyVMab1LCcJC8wovBgtq1OAuu7NclU jjNYl6lK0gRly75v7kjgLomvAQAjs/7Ci/slqMs1r7F7dHa2k9nLHkH+eY0X/q7JTXWp5LCBUEifq UYEXF4GRlhyt5wPj4REUVg==; In-Reply-To: <1d9187b71e7288eaf08ac9a2f0559bdf@gmail.com> (tomasralph2000@gmail.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272860 Archived-At: > Date: Fri, 20 Oct 2023 20:27:19 +0000 > From: tomasralph2000@gmail.com > > If using =display-line-numbers-mode= with the =visual= style set for it, > sometimes clicking buttons does not actually click it. It instead shifts > the buffer slightly, either to the left or to the right, and a mark is > set (by clicking I refer with the mouse, specifically). You will need to > press again in order to actually click the button. > > This is inconsistent, there's no guarantee that it will happen, it > sometimes does, but it is often enough for you to be able to notice within > just a couple of seconds of clicking through things. > > You can launch =emacs -Q= and run these two lines: > > (setq display-line-numbers-type 'visual) > (global-display-line-numbers-mode) > > Then just click through buttons. A good test is to open the emacs manual > =C-h R emacs= since it has a big index. Thanks, should be fixed now on the master branch. I only tested this in Info buffers, so any testing with other kinds of buttons/links will be welcome. Stefan, I'd appreciate your review of the change, as this is a tricky code, where we already had quite a few changes to avoid interpreting an up-event as a drag event.