From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Tue, 12 Dec 2023 21:16:45 +0200 Message-ID: <8334w7ten6.fsf@gnu.org> References: <878r919qfh.fsf@localhost> <87pm2584oz.fsf@localhost> <83cyy11ln1.fsf@gnu.org> <87lecp84mf.fsf@localhost> <83ttrdx8j9.fsf@gnu.org> <87a5su261p.fsf@localhost> <838r8e24yy.fsf@gnu.org> <87y1gezspg.fsf@localhost> <834jj21z05.fsf@gnu.org> <87il7izo4l.fsf@localhost> <831qe61xrh.fsf@gnu.org> <87cyxqzmhh.fsf@localhost> <83zg0uzlgw.fsf@gnu.org> <87v8bhxzcu.fsf@localhost> <83y1gdxws8.fsf@gnu.org> <87jzrwm7ul.fsf@localhost> <87h6n0m781.fsf@localhost> <87v8935wik.fsf@localhost> <83msuftr0i.fsf@gnu.org> <87plzbxtxa.fsf@localhost> <83fs07tjre.fsf@gnu.org> <87msufxqmo.fsf@localhost> <83a5qftghr.fsf@gnu.org> <0bbb45af-cca9-442a-837d-a173f7156248@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7276"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yantar92@posteo.net, monnier@iro.umontreal.ca, 66117@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 12 20:17:57 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rD8GS-0001bh-M5 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Dec 2023 20:17:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rD8GJ-0006E6-A4; Tue, 12 Dec 2023 14:17:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rD8GI-0006Dv-JN for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2023 14:17:46 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rD8GI-0007vl-B4 for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2023 14:17:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rD8GX-00062F-Qj for bug-gnu-emacs@gnu.org; Tue, 12 Dec 2023 14:18:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Dec 2023 19:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.170240865123162 (code B ref 66117); Tue, 12 Dec 2023 19:18:01 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 12 Dec 2023 19:17:31 +0000 Original-Received: from localhost ([127.0.0.1]:57582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rD8G0-00061S-9J for submit@debbugs.gnu.org; Tue, 12 Dec 2023 14:17:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rD8Fv-00061D-IN for 66117@debbugs.gnu.org; Tue, 12 Dec 2023 14:17:27 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rD8Fa-0007e9-1u; Tue, 12 Dec 2023 14:17:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mWTdrnITBAsFx6ZhKjw786rTFS7O9Wwng0MH21Njp84=; b=dHvA9ZanZDXr bWY4/qrbHw2uDXWx/+y+qUJMikvi8l1ELU61c7JiA2kZA6ngfKKQT9rRvAYiu4JytZRxRWNwFpV5g T5K21xMZQ5tsGceKx9RLrenX/ELlHbSz67NqTbVWOcTbVxUY5xniA428NnvtNzfIZQYJQR0rDnZJg gkOHN74qpfpKnQp//MrYKk7CMHWEiv5/o0H2rKyxX+LS2immkinAA30wJKv2BlLJzemo+dWq0KOLx yREvSVtTzf03SITfaXjIqXJB/VwxvDdWINXHmYK5PNfMjbtjJ6LhAxDrzLhTUwUyTRv2dvjTkAUC0 rdWTQwCbPJEz6ZpzoK8YVQ==; In-Reply-To: <0bbb45af-cca9-442a-837d-a173f7156248@gutov.dev> (message from Dmitry Gutov on Tue, 12 Dec 2023 21:10:13 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276074 Archived-At: > Date: Tue, 12 Dec 2023 21:10:13 +0200 > Cc: monnier@iro.umontreal.ca, 66117@debbugs.gnu.org > From: Dmitry Gutov > > On 12/12/2023 20:36, Eli Zaretskii wrote: > >> From: Ihor Radchenko > >> Cc:monnier@iro.umontreal.ca,dmitry@gutov.dev,66117@debbugs.gnu.org > >> Date: Tue, 12 Dec 2023 17:44:15 +0000 > >> > >> Eli Zaretskii writes: > >> > >>>> #define BVAR(buf, field) (buffer_overrides->field ## _ == UNSET ?\ > >>>> (buf)->field ## _ :\ > >>>> buffer_overrides->field ## _) > >>>> > >>>> and replace the loop with simply setting buffer_overrides slot. > >>> So for starters, we make each BVAR more expensive, i.e. make Emacs > >>> uniformly slower (because we call BVAR all over the place). > >> Yes, although I do not believe that it will have large impact in > >> practice. It is just an extra == comparison. > > We've seen how similar extra comparisons slow down Emacs when we > > introduced symbols-with-location. IMO, BVAR might be even more > > expensive, since it is used much more frequently and widely. > > We also have dynamic variable bindings all over the place But not all of them are special like case-fold-search. > so it might be worth a try (with measurements). I didn't say it isn't worth a try.