From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68334: 29.1; tool-bar-make-keymap-1 does not work on terminals Date: Tue, 09 Jan 2024 20:57:35 +0200 Message-ID: <8334v6pc68.fsf@gnu.org> References: <83le8yps3s.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27619"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jared@finder.org, 68334@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 09 19:59:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNHJd-000731-1g for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jan 2024 19:59:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNHJQ-0004OC-H6; Tue, 09 Jan 2024 13:58:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNHJP-0004O3-GU for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 13:58:55 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNHJP-0000M2-7n for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 13:58:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNHJV-0005qe-U7 for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 13:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jan 2024 18:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68334 X-GNU-PR-Package: emacs Original-Received: via spool by 68334-submit@debbugs.gnu.org id=B68334.170482669122415 (code B ref 68334); Tue, 09 Jan 2024 18:59:01 +0000 Original-Received: (at 68334) by debbugs.gnu.org; 9 Jan 2024 18:58:11 +0000 Original-Received: from localhost ([127.0.0.1]:40957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNHIg-0005pS-Pi for submit@debbugs.gnu.org; Tue, 09 Jan 2024 13:58:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNHIf-0005pG-CQ for 68334@debbugs.gnu.org; Tue, 09 Jan 2024 13:58:10 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNHIS-0008TS-4j; Tue, 09 Jan 2024 13:57:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=b+1LjwkUMSsrmLn+Thac4/xvQHJ/IVhX039S99bzOZI=; b=Ol1vXrfY/mOR 3bGOXFSU+iFacN9s40YubHH2ntor5mO0ctVL//0NwSYUINzFj1Fmm2qQnH2HqlyixUlclaxdVyrWH EjOsRDt/uHip8u9rWklzqqLSftyqTo0RNKqMnsIPYpaqKpGxZjmzt2QBW7yu1tpeFeYh57IZ+ceeh ZDnnduJOoRs796kS5Hu8g2aU2HzqnOBzosNTqNdRzix5P3x4kzDJM5slyaFF17aE72yJ43Re1K00h bNa5hG5cILUPnQJ7HffMLwjeoQM8A+O79Z3whfIKDAbleRdrFDMab5HJayR2fQw9SL4VR0bjuisBG El19Urtsocb71/O/GwynBg==; In-Reply-To: (message from Stefan Kangas on Tue, 9 Jan 2024 10:39:05 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277646 Archived-At: > From: Stefan Kangas > Date: Tue, 9 Jan 2024 10:39:05 -0800 > Cc: jared@finder.org, 68334@debbugs.gnu.org > > Eli Zaretskii writes: > > >> > Context: I am writing a package that displays toolbars attached to an > >> > Emacs window instead of attached to the frame. You can see the package > >> > at . > >> > >> Shouldn't this be a feature in core Emacs? I believe that we have > >> discussed that in the past. > >> > >> Eli, WDYT? > > > > I won't mind, if Jared thinks the package will be useful in enough > > situations or for enough packages. > > I didn't intend to propose including the existing implementation as is, > which I hadn't looked closely at. Having done that just now, it seems > like it's implemented on the tab bar, as Juri has pointed out. I think > this is probably not the right thing for a feature in Emacs itself. How else do you expect this to be implemented on TTY frames? It can either overwrite parts of the menu bar, or it could overwrite parts of the tab bar. Something's gotta give, no? I also don't understand why the tab bar is deemed more important than the tool bar. Let's let users decide what they prefer. (Of course, if there's a way to let them have the cake and eat it, too, that would be the best.) > This feature would be most useful as a first class feature, but that > might require C changes. IMO, usurping one more screen line from TTY frames could be problematic, especially on terminals that display a relatively small number of lines.