bug#7222: 24.0.50; image-checkbox-checked considered harmful

bug#7222: 24.0.50; image-checkbox-checked considered harmful

[Eli Zaretskii]

This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your report will be posted to the bug-gnu-emacs@gnu.org mailing list
and the gnu.emacs.bug news group, and at http://debbugs.gnu.org.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug.  If you can, give
a recipe starting from `emacs -Q':

This change:

  2010-10-11  Chong Yidong  <cyd@stupidchicken.com>

          * image.el (image-checkbox-checked, image-checkbox-unchecked): New
          variables, containing checkbox images.

makes it impossible to byte-compile any Lisp file that requires
`image' in an Emacs built without image support (e.g., --without-x on
GNU/Linux).  For example:

  Compiling iimage.el

  In toplevel form:
  iimage.el:47:13:Error: Invalid image type `xbm'
  make[2]: *** [iimage.elc] Error 1

The same error happens with image-file.el.

This is because the above two new defvar's call create-image, which
signals an error if an unsupported image type is called out.

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
d:/gnu/bzr/emacs/trunk/etc/DEBUG.


In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2010-10-15 on HOME-C4E4A596F7
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  value of $XMODIFIERS: nil
  locale-coding-system: cp1255
  default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x r e p o r t - e m a c s - b u f <backspace> g 
<return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr message rfc822 mml easymenu mml-sec
mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader
emacsbug tooltip ediff-hook vc-hooks lisp-float-type mwheel dos-w32
disp-table ls-lisp w32-win w32-vars tool-bar dnd fontset image fringe
lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
button minibuffer faces cus-face files text-properties overlay md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process multi-tty emacs)

bug#7222: 24.0.50; image-checkbox-checked considered harmful

[Glenn Morris]

Eli Zaretskii wrote:

> This is because the above two new defvar's call create-image, which
> signals an error if an unsupported image type is called out.

Does simply sticking `ignore-errors' around those create-image calls work?

bug#7222: 24.0.50; image-checkbox-checked considered harmful

[Eli Zaretskii]

> Cc: 7222@debbugs.gnu.org
> From: Glenn Morris <rgm@gnu.org>
> Date: Sat, 23 Oct 2010 16:16:01 -0400
> 
> Eli Zaretskii wrote:
> 
> > This is because the above two new defvar's call create-image, which
> > signals an error if an unsupported image type is called out.
> 
> Does simply sticking `ignore-errors' around those create-image calls work?

"Works" as in "does not produce error messages", or "works" as in
"produces .elc files that can then be run in a GUI session that
supports images"?

bug#7222: 24.0.50; image-checkbox-checked considered harmful

[Chong Yidong]

Eli Zaretskii <eliz@gnu.org> writes:

> This change:
>
>   2010-10-11  Chong Yidong  <cyd@stupidchicken.com>
>
>           * image.el (image-checkbox-checked, image-checkbox-unchecked): New
>           variables, containing checkbox images.
>
> makes it impossible to byte-compile any Lisp file that requires
> `image' in an Emacs built without image support (e.g., --without-x on
> GNU/Linux).

Thanks for spotting this.  I've checked in a fix.  (Basically, putting
the checkbox images in etc/images rather than making them inline.)