unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#11036: 24.0.94; imagemagick-render-type is void as a variable
@ 2012-03-17  3:07 Leo
  2012-03-17  8:52 ` Eli Zaretskii
  0 siblings, 1 reply; 8+ messages in thread
From: Leo @ 2012-03-17  3:07 UTC (permalink / raw)
  To: 11036

My emacs is built without imagemagick support and I am seeing this:

imagemagick-render-type is a variable defined in `C source code'.
It is void as a variable.

Documentation:
Integer indicating which ImageMagick rendering method to use.
The options are:
  0 -- the default method (pixel pushing)
  1 -- a newer method ("MagickExportImagePixels") that may perform
       better (speed etc) in some cases, but has not been as thoroughly
       tested with Emacs as the default method.  This method requires
       ImageMagick version 6.4.6 (approximately) or later.


Leo





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#11036: 24.0.94; imagemagick-render-type is void as a variable
  2012-03-17  3:07 bug#11036: 24.0.94; imagemagick-render-type is void as a variable Leo
@ 2012-03-17  8:52 ` Eli Zaretskii
  2012-03-17 13:10   ` Leo
  0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2012-03-17  8:52 UTC (permalink / raw)
  To: Leo; +Cc: 11036

> From: Leo <sdl.web@gmail.com>
> Date: Sat, 17 Mar 2012 11:07:10 +0800
> 
> My emacs is built without imagemagick support and I am seeing this:
> 
> imagemagick-render-type is a variable defined in `C source code'.
> It is void as a variable.
> 
> Documentation:
> Integer indicating which ImageMagick rendering method to use.
> The options are:
>   0 -- the default method (pixel pushing)
>   1 -- a newer method ("MagickExportImagePixels") that may perform
>        better (speed etc) in some cases, but has not been as thoroughly
>        tested with Emacs as the default method.  This method requires
>        ImageMagick version 6.4.6 (approximately) or later.

Why do you consider this a problem?





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#11036: 24.0.94; imagemagick-render-type is void as a variable
  2012-03-17  8:52 ` Eli Zaretskii
@ 2012-03-17 13:10   ` Leo
  2012-03-17 18:36     ` Glenn Morris
  0 siblings, 1 reply; 8+ messages in thread
From: Leo @ 2012-03-17 13:10 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 11036

On 2012-03-17 16:52 +0800, Eli Zaretskii wrote:
> Why do you consider this a problem?

Do you see other void variables show up in C-h v?

Leo





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#11036: 24.0.94; imagemagick-render-type is void as a variable
  2012-03-17 13:10   ` Leo
@ 2012-03-17 18:36     ` Glenn Morris
  2012-03-17 18:53       ` Glenn Morris
  0 siblings, 1 reply; 8+ messages in thread
From: Glenn Morris @ 2012-03-17 18:36 UTC (permalink / raw)
  To: Leo; +Cc: 11036

Leo wrote:

> On 2012-03-17 16:52 +0800, Eli Zaretskii wrote:
>> Why do you consider this a problem?
>
> Do you see other void variables show up in C-h v?

x-resource-name in a build without-x, for example.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#11036: 24.0.94; imagemagick-render-type is void as a variable
  2012-03-17 18:36     ` Glenn Morris
@ 2012-03-17 18:53       ` Glenn Morris
  2012-03-20 21:06         ` Glenn Morris
  0 siblings, 1 reply; 8+ messages in thread
From: Glenn Morris @ 2012-03-17 18:53 UTC (permalink / raw)
  To: Leo; +Cc: 11036


I guess it is because Snarf-documentation does not understand #ifdefs.
See also http://lists.gnu.org/archive/html/emacs-devel/2008-05/msg01545.html .
In this case, the symbol imagemagick-render-type appears in cus-start.el.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#11036: 24.0.94; imagemagick-render-type is void as a variable
  2012-03-17 18:53       ` Glenn Morris
@ 2012-03-20 21:06         ` Glenn Morris
  2012-03-20 23:56           ` Leo
  0 siblings, 1 reply; 8+ messages in thread
From: Glenn Morris @ 2012-03-20 21:06 UTC (permalink / raw)
  To: Leo; +Cc: 11036


Obviously not for 24.1, but the following seems to work.
Anything that is in DOC should be defined at startup if relevant to the
platform in use.

I compared the results of `C-h f TAB' and `C-h v TAB' with and without
this change, and it just removes a few more void things.
Eg for me, the variables: motif-version-string, gtk-version-string, 
ns-initialized.


*** src/doc.c	2012-02-06 16:53:51 +0000
--- src/doc.c	2012-03-20 20:50:48 +0000
***************
*** 671,676 ****
--- 671,677 ----
  		  /* Install file-position as variable-documentation property
  		     and make it negative for a user-variable
  		     (doc starts with a `*').  */
+                   if (!NILP (Fboundp (sym)))
                      Fput (sym, Qvariable_documentation,
                            make_number ((pos + end + 1 - buf)
                                         * (end[1] == '*' ? -1 : 1)));
***************
*** 678,685 ****
  
  	      /* Attach a docstring to a function?  */
  	      else if (p[1] == 'F')
  		store_function_docstring (sym, pos + end + 1 - buf);
! 
  	      else if (p[1] == 'S')
  		; /* Just a source file name boundary marker.  Ignore it.  */
  
--- 679,688 ----
  
  	      /* Attach a docstring to a function?  */
  	      else if (p[1] == 'F')
+                 {
+                   if (!NILP (Ffboundp (sym)))
                      store_function_docstring (sym, pos + end + 1 - buf);
!                 }
  	      else if (p[1] == 'S')
  		; /* Just a source file name boundary marker.  Ignore it.  */
  






^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#11036: 24.0.94; imagemagick-render-type is void as a variable
  2012-03-20 21:06         ` Glenn Morris
@ 2012-03-20 23:56           ` Leo
  2012-04-09 20:44             ` Glenn Morris
  0 siblings, 1 reply; 8+ messages in thread
From: Leo @ 2012-03-20 23:56 UTC (permalink / raw)
  To: 11036

On 2012-03-21 05:06 +0800, Glenn Morris wrote:
> Obviously not for 24.1, but the following seems to work.
> Anything that is in DOC should be defined at startup if relevant to the
> platform in use.

Thank you for fixing this.

Leo






^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#11036: 24.0.94; imagemagick-render-type is void as a variable
  2012-03-20 23:56           ` Leo
@ 2012-04-09 20:44             ` Glenn Morris
  0 siblings, 0 replies; 8+ messages in thread
From: Glenn Morris @ 2012-04-09 20:44 UTC (permalink / raw)
  To: 11036-done

Version: 24.2

Patch applied to trunk.





^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2012-04-09 20:44 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-17  3:07 bug#11036: 24.0.94; imagemagick-render-type is void as a variable Leo
2012-03-17  8:52 ` Eli Zaretskii
2012-03-17 13:10   ` Leo
2012-03-17 18:36     ` Glenn Morris
2012-03-17 18:53       ` Glenn Morris
2012-03-20 21:06         ` Glenn Morris
2012-03-20 23:56           ` Leo
2012-04-09 20:44             ` Glenn Morris

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).