From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11860: 24.1; Arabic - Harakat (diacritics, short vowels) don't appear Date: Mon, 20 Aug 2012 20:24:14 +0300 Message-ID: <831uj1cw8x.fsf@gnu.org> References: <878vdbhvc4.fsf@gnu.org> <83pq6md8lz.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1345483495 27307 80.91.229.3 (20 Aug 2012 17:24:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 20 Aug 2012 17:24:55 +0000 (UTC) Cc: 11860@debbugs.gnu.org, smias@yandex.ru To: handa@gnu.org, jasonr@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 20 19:24:55 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T3Vif-0004zm-IV for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Aug 2012 19:24:53 +0200 Original-Received: from localhost ([::1]:57850 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Vie-0003Lg-75 for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Aug 2012 13:24:52 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Vib-0003LK-GZ for bug-gnu-emacs@gnu.org; Mon, 20 Aug 2012 13:24:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3Via-0001xM-HV for bug-gnu-emacs@gnu.org; Mon, 20 Aug 2012 13:24:49 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3Via-0001xI-Dw for bug-gnu-emacs@gnu.org; Mon, 20 Aug 2012 13:24:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1T3Vio-0007Mm-8z for bug-gnu-emacs@gnu.org; Mon, 20 Aug 2012 13:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Aug 2012 17:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11860 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11860-submit@debbugs.gnu.org id=B11860.134548347028273 (code B ref 11860); Mon, 20 Aug 2012 17:25:02 +0000 Original-Received: (at 11860) by debbugs.gnu.org; 20 Aug 2012 17:24:30 +0000 Original-Received: from localhost ([127.0.0.1]:40293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T3ViH-0007Lx-Qm for submit@debbugs.gnu.org; Mon, 20 Aug 2012 13:24:30 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:54328) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T3ViG-0007Lq-FL for 11860@debbugs.gnu.org; Mon, 20 Aug 2012 13:24:29 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0M9200500DLOX500@a-mtaout21.012.net.il> for 11860@debbugs.gnu.org; Mon, 20 Aug 2012 20:24:12 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M920052QDOCS280@a-mtaout21.012.net.il>; Mon, 20 Aug 2012 20:24:12 +0300 (IDT) In-reply-to: <83pq6md8lz.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:63326 Archived-At: > Date: Sun, 19 Aug 2012 21:44:56 +0300 > From: Eli Zaretskii > Cc: 11860@debbugs.gnu.org, smias@yandex.ru > > > 2. Pass this array to ScriptLayout to generate a map of > > visual positions to logical positions. > > > > There's no place in Emacs that calls ScriptLayout. Isn't it > > a problem? > > I don't think so, at least not directly. ScriptLayout actually draws > the shaped glyphs on the screen. Emacs doesn't use it because it > draws the glyphs by itself, using the information in the glyph-strings > generated from the data returned by the shaping engine. Or am I > missing something? Answering my own question here: yes, I did miss something. We do call the 'draw' method of the font driver, in w32term.c. However, the Windows implementation of this is on w32font.c, and it calls ExtTextOutW, not ScriptTextOut. Which might be a problem, hmm... As for ScriptLayout, it is only needed for logical-to-visual reordering of _items_, whereas we always pass to Uniscribe a chunk of text that can only become a single item.