From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12993: Wrong icon for Cygw32-Emacs Date: Mon, 10 Dec 2012 21:57:23 +0200 Message-ID: <831uexbrz0.fsf@gnu.org> References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <83lid6auv1.fsf@gnu.org> <83k3sqatks.fsf@gnu.org> <50C60CBE.1070905@dancol.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1355169514 16507 80.91.229.3 (10 Dec 2012 19:58:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Dec 2012 19:58:34 +0000 (UTC) Cc: 12993@debbugs.gnu.org, angelo.graziosi@alice.it To: Daniel Colascione Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 10 20:58:46 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ti9Uw-0005tQ-M0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Dec 2012 20:58:42 +0100 Original-Received: from localhost ([::1]:33828 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti9Uk-0004Z0-9A for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Dec 2012 14:58:30 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:51562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti9Ug-0004Yr-Hc for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2012 14:58:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ti9Uf-0004iZ-8h for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2012 14:58:26 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ti9Uf-0004iT-5R for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2012 14:58:25 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Ti9VF-0004Ev-Kl for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2012 14:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Dec 2012 19:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12993-submit@debbugs.gnu.org id=B12993.135516950416247 (code B ref 12993); Mon, 10 Dec 2012 19:59:01 +0000 Original-Received: (at 12993) by debbugs.gnu.org; 10 Dec 2012 19:58:24 +0000 Original-Received: from localhost ([127.0.0.1]:35895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti9Ue-0004E0-Dm for submit@debbugs.gnu.org; Mon, 10 Dec 2012 14:58:24 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:45740) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ti9Ua-0004Dp-W0 for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 14:58:22 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MET00E00YRIWD00@a-mtaout22.012.net.il> for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 21:57:32 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MET00E07ZFUM5A0@a-mtaout22.012.net.il>; Mon, 10 Dec 2012 21:57:31 +0200 (IST) In-reply-to: <50C60CBE.1070905@dancol.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:68289 Archived-At: > Date: Mon, 10 Dec 2012 08:24:30 -0800 > From: Daniel Colascione > CC: 12993@debbugs.gnu.org, angelo.graziosi@alice.it > > > SetErrorMode (SEM_FAILCRITICALERRORS); > > - > > - /* Invoke the NT CRT startup routine now that our housecleaning > > - is finished. */ > > -#ifdef HAVE_NTGUI > > - /* determine WinMain args like crt0.c does */ > > - hinst = GetModuleHandle (NULL); > > - lpCmdLine = GetCommandLine (); > > - nCmdShow = SW_SHOWDEFAULT; > > -#endif > > mainCRTStartup (); > > } > > > > What do you know about lpCmdLine and nCmdShow, and "what crt0.c does" > > with them, to be sure they can be removed? > > I removed dead code. Those variables are never used; the C runtime (to > which we dynamically link anyway) handles this initialization > internally. I'm not sure. To me, it looks like we are _replacing_ the _start function from the C runtime, and therefore whoever wrote this code wanted to do things like the C runtime does. I see similar code in crt0.c from the Windows Platform SDK. If you know why this is dead code, please tell the details. > (We appear to have a separate bug with respect to > nCmdShow: create a shortcut to runemacs.exe and set it to start > minimized or start maximized. Emacs starts with a normal window.) The equivalent code in crt0.c indeed looks at dwFlags member of STARTUPINFO. So I guess this is evidence that this code does matter, right? > > And this hunk breaks the MS-DOS build: > > *sigh* The MS-DOS build breaks when the wind blows the wrong way. That's an exaggeration. There's no evidence for that. > Does the build work inside DOSBox? I'll have to start testing the > build in that environment before pushing. There's no need. The DOS build can remain broken on the trunk for prolonged periods, because no one tracks that. I usually test the build at strategic moments, and fix whatever needs fixing. For this pretest, I already did that on the branch, and I'd like to keep it functional if possible. In general, any introduction of a new variable in src/Makefile.in that gets replaced by the configure script should be edited by msdos/sed1v2.inp, usually to an empty value. But if the configury stuff doesn't change during a pretest, no changes are needed in msdos/* files. Anyway, when in doubt, just ask me, I can test if needed.