From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#13553: 24.3.50; incorrect usage of IS_DIRECTORY_SEP Date: Sun, 27 Jan 2013 09:15:45 +0200 Message-ID: <831ud7jdum.fsf@gnu.org> References: <83libgje5t.fsf@gnu.org> <83d2wrkfpm.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1359271016 10656 80.91.229.3 (27 Jan 2013 07:16:56 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Jan 2013 07:16:56 +0000 (UTC) Cc: 13553-done@debbugs.gnu.org To: Shigeru Fukaya Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 27 08:17:15 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TzMUK-0005s5-El for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Jan 2013 08:17:12 +0100 Original-Received: from localhost ([::1]:56736 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzMU2-0004ox-LS for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Jan 2013 02:16:54 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzMU0-0004os-0K for bug-gnu-emacs@gnu.org; Sun, 27 Jan 2013 02:16:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TzMTt-00036r-2y for bug-gnu-emacs@gnu.org; Sun, 27 Jan 2013 02:16:51 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TzMTs-00036f-Vw for bug-gnu-emacs@gnu.org; Sun, 27 Jan 2013 02:16:45 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TzMUA-0001tY-Lz for bug-gnu-emacs@gnu.org; Sun, 27 Jan 2013 02:17:02 -0500 Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Jan 2013 07:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 13553 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 13553@debbugs.gnu.org, eliz@gnu.org, shigeru.fukaya@gmail.com Original-Received: via spool by 13553-done@debbugs.gnu.org id=D13553.13592709697213 (code D ref 13553); Sun, 27 Jan 2013 07:17:02 +0000 Original-Received: (at 13553-done) by debbugs.gnu.org; 27 Jan 2013 07:16:09 +0000 Original-Received: from localhost ([127.0.0.1]:50981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzMTJ-0001sI-4I for submit@debbugs.gnu.org; Sun, 27 Jan 2013 02:16:09 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:62741) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TzMTF-0001s7-6c for 13553-done@debbugs.gnu.org; Sun, 27 Jan 2013 02:16:06 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MH900C00W039C00@a-mtaout20.012.net.il> for 13553-done@debbugs.gnu.org; Sun, 27 Jan 2013 09:15:33 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MH900CAJW5W3L40@a-mtaout20.012.net.il>; Sun, 27 Jan 2013 09:15:33 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70367 Archived-At: > From: Shigeru Fukaya > Cc: 13553@debbugs.gnu.org > Date: Sun, 27 Jan 2013 15:56:54 +0900 > > Built on migw32, and no trouble, thank you > (I didn't do coverage tests, sorry). Thanks. I'm therefore closing this bug. > But we must remember, my raise of issue is the incorrect usage of > IS_DIRECTORY_SEP. There are still more in fileio.c and more. Yes. This is being discussed on emacs-devel, and once that discussion ends, the fileio.c and dired.c functions will be fixed as well. > >> As for coding symbol, not a few Japanese use 'cp932 not 'shift-jis I > >> suppose. But we need some notice for users. > > > >Not sure what you are saying here. Do you think many Japanese Windows > >users will set file-name-coding-system to shift_jis, or that most of > >them will set it to cp932? > > > >Normally, users don't customize file-name-coding-system at all, in > >which case Emacs will use default-file-name-coding-system, that is > >automatically set to cp932, according to the system-wide codepage. > > Yes, you are right. I mean, maybe, the case of using some remote file > system. Accessing remote files doesn't go through functions in w32.c, it goes through file handlers (in Tramp). > You can check by yourself their (our?) usage if you like. > Some seems still using shift-jis, not cp932. > > http://www.google.co.jp/search?q=file-name-coding-system+sjis If they want 100% solid support, they will have to change their customizations, sorry. (We could implement an equivalence table, whereby, e.g., shift_jis would be mapped to cp932, but these encodings are slightly different, so I think that would be a kludge.) In any case, the new code in w32.c is no worse than the previous one, when file-name-coding-system is set to anything that is not a recognized Windows codepage. It is actually slightly better: it uses the system-wide ANSI codepage in that case. In most cases, this would be the right thing anyway.