From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18051: 24.3.92; ls-lisp: Sorting; make ls-lisp-string-lessp a normal function? Date: Fri, 18 Jul 2014 12:46:26 +0300 Message-ID: <831ttj6lu5.fsf@gnu.org> References: <87ha2f5gp8.fsf@web.de> <838unr6ttu.fsf@gnu.org> <871ttj5dfi.fsf@web.de> <837g3b6ob7.fsf@gnu.org> <874myfatyo.fsf@web.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1405676849 32519 80.91.229.3 (18 Jul 2014 09:47:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 18 Jul 2014 09:47:29 +0000 (UTC) Cc: 18051@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 18 11:47:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X84l7-0000Mw-1K for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Jul 2014 11:47:21 +0200 Original-Received: from localhost ([::1]:48871 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X84l6-0001Y5-Mc for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Jul 2014 05:47:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X84kv-0001PB-Sf for bug-gnu-emacs@gnu.org; Fri, 18 Jul 2014 05:47:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X84ko-0000aF-OV for bug-gnu-emacs@gnu.org; Fri, 18 Jul 2014 05:47:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X84ko-0000ZY-KY for bug-gnu-emacs@gnu.org; Fri, 18 Jul 2014 05:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X84ko-00075v-0E for bug-gnu-emacs@gnu.org; Fri, 18 Jul 2014 05:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Jul 2014 09:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18051-submit@debbugs.gnu.org id=B18051.140567681427254 (code B ref 18051); Fri, 18 Jul 2014 09:47:01 +0000 Original-Received: (at 18051) by debbugs.gnu.org; 18 Jul 2014 09:46:54 +0000 Original-Received: from localhost ([127.0.0.1]:57943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X84kb-00075K-0O for submit@debbugs.gnu.org; Fri, 18 Jul 2014 05:46:53 -0400 Original-Received: from mtaout29.012.net.il ([80.179.55.185]:32900) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X84kU-00074y-A8 for 18051@debbugs.gnu.org; Fri, 18 Jul 2014 05:46:47 -0400 Original-Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0N8W00D00IMW0M00@mtaout29.012.net.il> for 18051@debbugs.gnu.org; Fri, 18 Jul 2014 12:46:36 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N8W005W4J5O0CA0@mtaout29.012.net.il>; Fri, 18 Jul 2014 12:46:36 +0300 (IDT) In-reply-to: <874myfatyo.fsf@web.de> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91630 Archived-At: > From: Michael Heerdegen > Cc: 18051@debbugs.gnu.org > Date: Fri, 18 Jul 2014 11:37:19 +0200 > > Eli Zaretskii writes: > > > > could I please get my `ls-lisp-string-lessp' defined as a function? > > > > You can always redefine the functions that call it, no? > > That would cover the whole switch processing algorithm, > `ls-lisp-handle-switches', 60 lines of code. I would shadow any future > change in that code by redefining that huge function. That's why I > wanted to avoid that. You are going to override the behavior of the package anyway, so I don't see the big difference. > What's the advantage of `ls-lisp-string-lessp' being a defsubst? >From my POV, making sure the package always behaves as designed, I guess. You agreed with my motivation, so it sounds like a contradiction to me to still push for the change. Anyway, if others think the comparison of file names should be up for grabs, I won't fight the change just because I think it's wrong.