From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18360: Modularize recent qsort_r additions Date: Sat, 30 Aug 2014 10:29:44 +0300 Message-ID: <831tryigev.fsf@gnu.org> References: <5400E959.3000805@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1409383829 978 80.91.229.3 (30 Aug 2014 07:30:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Aug 2014 07:30:29 +0000 (UTC) Cc: 18360@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 30 09:30:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XNd76-0000dw-Sm for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Aug 2014 09:30:20 +0200 Original-Received: from localhost ([::1]:45525 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNd76-0000ek-7v for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Aug 2014 03:30:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNd6x-0000dh-Mh for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 03:30:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNd6q-0002oL-CS for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 03:30:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNd6q-0002lh-7h for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 03:30:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XNd6p-0007l1-0V for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 03:30:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Aug 2014 07:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18360 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 18360-submit@debbugs.gnu.org id=B18360.140938379229778 (code B ref 18360); Sat, 30 Aug 2014 07:30:02 +0000 Original-Received: (at 18360) by debbugs.gnu.org; 30 Aug 2014 07:29:52 +0000 Original-Received: from localhost ([127.0.0.1]:53961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNd6d-0007kD-Tk for submit@debbugs.gnu.org; Sat, 30 Aug 2014 03:29:52 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:51629) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNd6a-0007ju-Iw for 18360@debbugs.gnu.org; Sat, 30 Aug 2014 03:29:49 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NB300400Z1HXD00@a-mtaout22.012.net.il> for 18360@debbugs.gnu.org; Sat, 30 Aug 2014 10:29:42 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NB300401ZHHSY30@a-mtaout22.012.net.il>; Sat, 30 Aug 2014 10:29:42 +0300 (IDT) In-reply-to: <5400E959.3000805@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92844 Archived-At: > Date: Fri, 29 Aug 2014 13:58:01 -0700 > From: Paul Eggert > > The recent changes to have Emacs use qsort_r look good except for the > forest of #ifdefs in Emacs proper. Attached is a proposed patch to > migrate that stuff into Gnulib. As usual most of this patch is > automatically generated; fns.c contains the crucial hand-generated > stuff. I have not tested this on Microsoft Windows and so am posting it > here first to give Eli a heads-up. Why is it a good idea to use qsort_r? It's evidently not portable enough, and its benefits for Emacs at this time are nil, AFAICT. I say let's wait until we really need a reentrant sort function, and introduce it then. qsort is good enough for us for now.