From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 18360@debbugs.gnu.org
Subject: bug#18360: Modularize recent qsort_r additions
Date: Sat, 30 Aug 2014 10:29:44 +0300 [thread overview]
Message-ID: <831tryigev.fsf@gnu.org> (raw)
In-Reply-To: <5400E959.3000805@cs.ucla.edu>
> Date: Fri, 29 Aug 2014 13:58:01 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
>
> The recent changes to have Emacs use qsort_r look good except for the
> forest of #ifdefs in Emacs proper. Attached is a proposed patch to
> migrate that stuff into Gnulib. As usual most of this patch is
> automatically generated; fns.c contains the crucial hand-generated
> stuff. I have not tested this on Microsoft Windows and so am posting it
> here first to give Eli a heads-up.
Why is it a good idea to use qsort_r? It's evidently not portable
enough, and its benefits for Emacs at this time are nil, AFAICT.
I say let's wait until we really need a reentrant sort function, and
introduce it then. qsort is good enough for us for now.
next prev parent reply other threads:[~2014-08-30 7:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 20:58 bug#18360: Modularize recent qsort_r additions Paul Eggert
2014-08-30 7:29 ` Eli Zaretskii [this message]
2014-08-30 13:44 ` Paul Eggert
2014-08-30 14:15 ` Eli Zaretskii
2014-08-30 16:39 ` Paul Eggert
2014-08-30 16:43 ` Eli Zaretskii
2014-08-30 16:44 ` Paul Eggert
2014-08-30 16:56 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831tryigev.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=18360@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).