From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash Date: Tue, 26 Jan 2016 22:15:22 +0200 Message-ID: <831t9414it.fsf@gnu.org> References: <87y4bcsogq.fsf@gmail.com> <83powo1j71.fsf@gnu.org> <87io2gns3b.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1453839394 12781 80.91.229.3 (26 Jan 2016 20:16:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Jan 2016 20:16:34 +0000 (UTC) Cc: 22466@debbugs.gnu.org To: Artur Malabarba Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 26 21:16:20 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aOA2F-0005hK-F3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Jan 2016 21:16:19 +0100 Original-Received: from localhost ([::1]:46530 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOA2E-0002ZJ-S5 for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Jan 2016 15:16:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOA21-0002MN-OC for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 15:16:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOA1y-0007b5-Ju for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 15:16:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOA1y-0007b1-GW for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 15:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aOA1y-00083v-DC for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 15:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Jan 2016 20:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22466 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22466-submit@debbugs.gnu.org id=B22466.145383930330902 (code B ref 22466); Tue, 26 Jan 2016 20:16:02 +0000 Original-Received: (at 22466) by debbugs.gnu.org; 26 Jan 2016 20:15:03 +0000 Original-Received: from localhost ([127.0.0.1]:37937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aOA11-00082L-CU for submit@debbugs.gnu.org; Tue, 26 Jan 2016 15:15:03 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:60652) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aOA10-00081c-2J for 22466@debbugs.gnu.org; Tue, 26 Jan 2016 15:15:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOA0r-0007Dv-My for 22466@debbugs.gnu.org; Tue, 26 Jan 2016 15:14:56 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42907) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOA0r-0007Dn-J9; Tue, 26 Jan 2016 15:14:53 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1591 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aOA0q-0002HB-SS; Tue, 26 Jan 2016 15:14:53 -0500 In-reply-to: <87io2gns3b.fsf@gmail.com> (message from Artur Malabarba on Tue, 26 Jan 2016 17:25:36 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112014 Archived-At: > From: Artur Malabarba > Cc: 22466@debbugs.gnu.org > Date: Tue, 26 Jan 2016 17:25:36 +0000 > > >> (set-frame-parameter frame 'background-color > >> (custom--frame-color-default > >> frame :background "background" "Background" > >> "unspecified-bg" "white")) > >> > >> I'm not saying this form is wrong. I'm just pointing to where it happens. > > > > What happens if you remove that from disable-theme? > > Then there's no flashing, but then if I simply disable the theme > (without enabling a new one) I'm left with theme's background. So disable-theme actually means go back to the default theme? If so, when someone changes a theme, they don't really need to call disable-theme, right? They could just call load-theme with the new theme as an argument? > I never change my main color theme, but I always have a second theme > enabled that only affects the mode-line. This second theme is changed > occasionally and it always causes a flash (even though the theme has > nothing to do with the background). > > Besides, custom themes are not just for faces. This also came up because > someone is writing a package that simultaneously toggles between > different values for a set of variables (called a context) using > custom-themes. That's something that's designed to be used a couple > times a day. Then it would make sense to find a way of switching a theme without changing the frame's background color, if that's possible (i.e. if the new theme keeps the same background color). If there's a function missing for that, I'd suggest to add one.