From: Eli Zaretskii <eliz@gnu.org>
To: Artur Malabarba <bruce.connor.am@gmail.com>
Cc: 22466@debbugs.gnu.org
Subject: bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash
Date: Tue, 26 Jan 2016 22:15:22 +0200 [thread overview]
Message-ID: <831t9414it.fsf@gnu.org> (raw)
In-Reply-To: <87io2gns3b.fsf@gmail.com> (message from Artur Malabarba on Tue, 26 Jan 2016 17:25:36 +0000)
> From: Artur Malabarba <bruce.connor.am@gmail.com>
> Cc: 22466@debbugs.gnu.org
> Date: Tue, 26 Jan 2016 17:25:36 +0000
>
> >> (set-frame-parameter frame 'background-color
> >> (custom--frame-color-default
> >> frame :background "background" "Background"
> >> "unspecified-bg" "white"))
> >>
> >> I'm not saying this form is wrong. I'm just pointing to where it happens.
> >
> > What happens if you remove that from disable-theme?
>
> Then there's no flashing, but then if I simply disable the theme
> (without enabling a new one) I'm left with theme's background.
So disable-theme actually means go back to the default theme? If so,
when someone changes a theme, they don't really need to call
disable-theme, right? They could just call load-theme with the new
theme as an argument?
> I never change my main color theme, but I always have a second theme
> enabled that only affects the mode-line. This second theme is changed
> occasionally and it always causes a flash (even though the theme has
> nothing to do with the background).
>
> Besides, custom themes are not just for faces. This also came up because
> someone is writing a package that simultaneously toggles between
> different values for a set of variables (called a context) using
> custom-themes. That's something that's designed to be used a couple
> times a day.
Then it would make sense to find a way of switching a theme without
changing the frame's background color, if that's possible (i.e. if the
new theme keeps the same background color). If there's a function
missing for that, I'd suggest to add one.
next prev parent reply other threads:[~2016-01-26 20:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 9:02 bug#22466: 25.0.50; disable-theme apparently forces a redisplay and causes a screen flash Artur Malabarba
2016-01-26 14:58 ` Eli Zaretskii
2016-01-26 16:36 ` Drew Adams
2016-01-26 17:03 ` Eli Zaretskii
2016-01-26 18:41 ` Michael Albinus
2016-01-26 18:55 ` Eli Zaretskii
2016-01-26 19:31 ` Michael Albinus
[not found] ` <<87y4bc89pt.fsf@gmx.de>
[not found] ` <<834me01881.fsf@gnu.org>
2016-01-26 23:02 ` Drew Adams
2016-01-26 17:25 ` Artur Malabarba
2016-01-26 20:15 ` Eli Zaretskii [this message]
2016-01-27 20:20 ` Artur Malabarba
2016-01-28 3:36 ` Eli Zaretskii
[not found] <<87y4bcsogq.fsf@gmail.com>
[not found] ` <<83powo1j71.fsf@gnu.org>
[not found] ` <<1bbf7218-bd5b-4618-822c-cd75884a81ee@default>
[not found] ` <<83d1so1df3.fsf@gnu.org>
2016-01-26 17:07 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831t9414it.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=22466@debbugs.gnu.org \
--cc=bruce.connor.am@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).