From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23074: 25.1.50; X11: `use-fancy-splash-screens-p` erroneously returns nil. Date: Mon, 21 Mar 2016 18:03:24 +0200 Message-ID: <831t737r8z.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1458576268 23248 80.91.229.3 (21 Mar 2016 16:04:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Mar 2016 16:04:28 +0000 (UTC) Cc: 23074@debbugs.gnu.org To: Keith David Bershatsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 21 17:04:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ai2JT-0001e2-JC for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 17:04:15 +0100 Original-Received: from localhost ([::1]:58749 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai2JS-0004PN-Vg for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 12:04:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai2JK-0004GC-82 for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 12:04:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai2JG-00032Y-Bu for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 12:04:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60016) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai2JG-00032S-9S for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 12:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ai2JG-0000F2-3e for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 12:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Mar 2016 16:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23074 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23074-submit@debbugs.gnu.org id=B23074.1458576240914 (code B ref 23074); Mon, 21 Mar 2016 16:04:02 +0000 Original-Received: (at 23074) by debbugs.gnu.org; 21 Mar 2016 16:04:00 +0000 Original-Received: from localhost ([127.0.0.1]:57142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ai2JE-0000Eg-6N for submit@debbugs.gnu.org; Mon, 21 Mar 2016 12:04:00 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ai2JD-0000EU-0o for 23074@debbugs.gnu.org; Mon, 21 Mar 2016 12:03:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai2J2-0002xz-AB for 23074@debbugs.gnu.org; Mon, 21 Mar 2016 12:03:53 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58437) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai2J2-0002xh-7v; Mon, 21 Mar 2016 12:03:48 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2815 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ai2J1-0005UT-1B; Mon, 21 Mar 2016 12:03:47 -0400 In-reply-to: (message from Keith David Bershatsky on Sun, 20 Mar 2016 22:08:43 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115239 Archived-At: > Date: Sun, 20 Mar 2016 22:08:43 -0700 > From: Keith David Bershatsky > > Emacs master branch built `--with-x --with-ns=no` with full image support on an OSX machine (10.6.8) does not display the Emacs logo on the Welcome screen because the final test of `use-fancy-splash-screen-p` returns nil. If we use 17 instead of 19, the test returns `t` and the Emacs logo is displayed. > > I would suggest using a better test like `one-window-p`, because 19 is too big. > > (defun use-fancy-splash-screens-p () > "Return t if fancy splash screens should be used." > (when (and (display-graphic-p) > (or (and (display-color-p) > (image-type-available-p 'xpm)) > (image-type-available-p 'pbm))) > (let ((frame (fancy-splash-frame))) > (when frame > (let* ((img (create-image (fancy-splash-image-file))) > (image-height (and img (cdr (image-size img nil frame)))) > ;; We test frame-height so that, if the frame is split > ;; by displaying a warning, that doesn't cause the normal > ;; splash screen to be used. > (frame-height (1- (frame-height frame)))) > ;; The original value added to the `image-height' for the test was 19; however, > ;; that causes the test to fail on X11 by about 1.5 -- so use 17 instead. > (> frame-height (+ image-height 17))))))) I would like to understand the situation before discussing the solution. Please tell what these two evaluations yield in "emacs -q": M-: (frame-height) RET M-: (image-size (create-image (fancy-splash-image-file))) RET On my system, the first one produces 35, the second (41.625 . 14.5625). Thanks.