From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 23779@debbugs.gnu.org, schwab@linux-m68k.org, dgutov@yandex.ru,
npostavs@users.sourceforge.net
Subject: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env
Date: Sun, 19 Jun 2016 18:01:13 +0300 [thread overview]
Message-ID: <831t3t9q9y.fsf@gnu.org> (raw)
In-Reply-To: <57660314.9050907@cs.ucla.edu> (message from Paul Eggert on Sun, 19 Jun 2016 04:27:32 +0200)
> Cc: npostavs@users.sourceforge.net, 23779@debbugs.gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Sun, 19 Jun 2016 04:27:32 +0200
>
> On 06/17/2016 04:19 PM, Eli Zaretskii wrote:
> >> Looks like it does. Please push at your convenience.
> > I'd like the patch to be eyeballed by a few more people. Paul,
> > Andreas, do you see any problems with it? If not, I'd like to push it
> > to the emacs-25 branch
> The patch is correct.
Thanks for the review. I will push the patch soon to emacs-25.
> The code is tricky so I'm not surprised you wanted another pair of
> eyes.
Indeed.
> The attached patch is a very minor tweak of your
> patch that made it a bit easier for me to follow.
I think I will go with my version, mainly because it will most
probably be short-lived, and so is not worth optimizing.
> I resisted the temptation of cleaning up the surrounding code to
> make it more readable.
Feel free to do that on master; I can mark the emacs-25 fix "not to be
merged".
next prev parent reply other threads:[~2016-06-19 15:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 3:33 bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env Noam Postavsky
2016-06-17 7:11 ` Eli Zaretskii
2016-06-17 12:17 ` Dmitry Gutov
2016-06-17 14:01 ` Eli Zaretskii
2016-06-17 14:12 ` Dmitry Gutov
2016-06-17 14:19 ` Eli Zaretskii
2016-06-17 14:47 ` Dmitry Gutov
2016-06-17 16:52 ` Andreas Schwab
2016-06-17 16:55 ` Dmitry Gutov
2016-06-17 17:06 ` Eli Zaretskii
2016-06-17 19:01 ` Dmitry Gutov
2016-06-17 20:10 ` Eli Zaretskii
2016-06-17 21:26 ` Dmitry Gutov
2016-06-18 7:51 ` Eli Zaretskii
2016-06-18 1:36 ` Noam Postavsky
2016-06-18 1:44 ` Dmitry Gutov
2016-06-19 2:27 ` Paul Eggert
2016-06-19 15:01 ` Eli Zaretskii [this message]
2016-06-19 22:53 ` Paul Eggert
2016-06-20 14:21 ` Eli Zaretskii
2016-06-21 13:53 ` Dmitry Gutov
2016-06-21 15:21 ` Eli Zaretskii
2016-06-21 15:24 ` Dmitry Gutov
2016-06-21 16:12 ` Eli Zaretskii
2016-06-21 23:05 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831t3t9q9y.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23779@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=eggert@cs.ucla.edu \
--cc=npostavs@users.sourceforge.net \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).