From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23917: [O] bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template =?UTF-8?Q?=E2=80=98g=E2=80=99:?= Match data clobbered by buffer modification hooks) Date: Tue, 19 Jul 2016 21:44:19 +0300 Message-ID: <831t2p1n98.fsf__3715.33637303418$1468957636$gmane$org@gnu.org> References: <87vb066ejv.fsf@linaro.org> <8360s67qcp.fsf@gnu.org> <87bn1yyaui.fsf@linaro.org> <87mvlhmv0x.fsf_-_@moondust.awandering> <837fcl5zs9.fsf@gnu.org> <87a8hgkwcb.fsf@linaro.org> <8360s42mcb.fsf@gnu.org> <87eg6rgmlg.fsf@gmail.com> <83lh0y24y6.fsf@gnu.org> <83eg6q1hbo.fsf@gnu.org> <83a8hd1vzi.fsf@gnu.org> <834m7l1u8u.fsf@gnu.org> <87a8hdmuce.fsf@linaro.org> <8337n51r4f.fsf@gnu.org> <878twxmshj.fsf@linaro.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1468957636 18641 80.91.229.3 (19 Jul 2016 19:47:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Jul 2016 19:47:16 +0000 (UTC) Cc: 23917@debbugs.gnu.org, rpluim@gmail.com, jwiegley@gmail.com, monnier@iro.umontreal.ca, nljlistbox2@gmail.com To: Alex =?UTF-8?Q?Benn=C3=A9e?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 19 21:47:06 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bPayv-0006iT-MO for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jul 2016 21:47:05 +0200 Original-Received: from localhost ([::1]:58320 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPayv-0007qI-0m for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jul 2016 15:47:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPa0y-00083E-R3 for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2016 14:45:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPa0x-0004qB-Ty for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2016 14:45:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45255) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPa0s-0004nM-2k; Tue, 19 Jul 2016 14:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bPa0r-00087T-Sf; Tue, 19 Jul 2016 14:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Tue, 19 Jul 2016 18:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23917 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Original-Received: via spool by 23917-submit@debbugs.gnu.org id=B23917.146895388131160 (code B ref 23917); Tue, 19 Jul 2016 18:45:01 +0000 Original-Received: (at 23917) by debbugs.gnu.org; 19 Jul 2016 18:44:41 +0000 Original-Received: from localhost ([127.0.0.1]:57592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPa0W-00086W-QC for submit@debbugs.gnu.org; Tue, 19 Jul 2016 14:44:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPa0U-00086F-U9 for 23917@debbugs.gnu.org; Tue, 19 Jul 2016 14:44:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPa0O-0004is-S1 for 23917@debbugs.gnu.org; Tue, 19 Jul 2016 14:44:33 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPa0I-0004i2-B4; Tue, 19 Jul 2016 14:44:26 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3775 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bPa0G-0006I2-JE; Tue, 19 Jul 2016 14:44:25 -0400 In-reply-to: <878twxmshj.fsf@linaro.org> (message from Alex =?UTF-8?Q?Benn=C3=A9e?= on Tue, 19 Jul 2016 18:45:44 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121272 Archived-At: > From: Alex Bennée > Cc: monnier@iro.umontreal.ca, 23917@debbugs.gnu.org, rpluim@gmail.com, jwiegley@gmail.com, nljlistbox2@gmail.com, me@lunaryorn.com > Date: Tue, 19 Jul 2016 18:45:44 +0100 > > ;; Save and restore the match data, as recommended in (elisp)Change Hooks > (save-match-data > (when flycheck-mode > ;; The buffer was changed, thus clear the idle timer > (flycheck-clear-idle-change-timer) > (if (string-match-p (rx "\n") (buffer-substring beg end)) > (flycheck-buffer-automatically 'new-line 'force-deferred) > (setq flycheck-idle-change-timer > (run-at-time flycheck-idle-change-delay nil > #'flycheck-handle-idle-change)))))) > > However it doesn't look as though it tweaks the buffer until idle timer > has run. Weird.... Tweaking the buffer is not what causes the problem. It's the call to save-match-data itself. It doesn't matter at all what the code inside save-match-data does.