From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix Date: Sun, 28 Aug 2016 17:31:22 +0300 Message-ID: <831t19c6dh.fsf@gnu.org> References: <83d1kud3m1.fsf@gnu.org> <83a8fyd1x0.fsf@gnu.org> <87oa4e1raw.fsf@zigzag.favinet> <838tvicuy3.fsf@gnu.org> <837fb2cqx1.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1472394740 13595 195.159.176.226 (28 Aug 2016 14:32:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 28 Aug 2016 14:32:20 +0000 (UTC) Cc: ttn@gnu.org, 24317@debbugs.gnu.org, schwab@linux-m68k.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 28 16:32:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1be18A-0002u0-8D for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Aug 2016 16:32:14 +0200 Original-Received: from localhost ([::1]:39606 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1be187-0000W8-Hg for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Aug 2016 10:32:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1be17z-0000Vq-Sy for bug-gnu-emacs@gnu.org; Sun, 28 Aug 2016 10:32:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1be17y-0006MM-09 for bug-gnu-emacs@gnu.org; Sun, 28 Aug 2016 10:32:02 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1be17x-0006MI-Su for bug-gnu-emacs@gnu.org; Sun, 28 Aug 2016 10:32:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1be17x-000584-OQ for bug-gnu-emacs@gnu.org; Sun, 28 Aug 2016 10:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Aug 2016 14:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24317 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24317-submit@debbugs.gnu.org id=B24317.147239471319703 (code B ref 24317); Sun, 28 Aug 2016 14:32:01 +0000 Original-Received: (at 24317) by debbugs.gnu.org; 28 Aug 2016 14:31:53 +0000 Original-Received: from localhost ([127.0.0.1]:42854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1be17p-00057j-N2 for submit@debbugs.gnu.org; Sun, 28 Aug 2016 10:31:53 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1be17o-00057W-99 for 24317@debbugs.gnu.org; Sun, 28 Aug 2016 10:31:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1be17g-0006Jv-31 for 24317@debbugs.gnu.org; Sun, 28 Aug 2016 10:31:47 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1be17W-0006IQ-C1; Sun, 28 Aug 2016 10:31:34 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1749 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1be17T-0000RE-S2; Sun, 28 Aug 2016 10:31:32 -0400 In-reply-to: (message from Tino Calancha on Sun, 28 Aug 2016 21:26:23 +0900 (JST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122742 Archived-At: > > I think we should indeed use image-type instead of having yet another > > function that recognizes JPEG. The problem I pointed out should be > > fixed in image-type-from-file-name, regardless. > I see. I have prepared following new patch: > > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > >From b953d600a295e4e0aa58b85126296663e7f02472 Mon Sep 17 00:00:00 2001 > From: Tino Calancha > Date: Sun, 28 Aug 2016 21:20:22 +0900 > Subject: [PATCH] image-type-from-file-name: Perform a case insensitive > match > > Fix Bug#24317 > * lisp/image.el (image-type-from-file-name): Bind case-fold-search > to a non-nil value to force a case insensitive match. > * lisp/image-dired.el (image-dired-rotate-original): > Use image-type (Bug#24317). > (image-dired-get-exif-file-name): Idem. > Set 'no-exif-data-found' and 'data' in same setq call. > Use file-attribute-modification-time. Thanks, this looks good to me. Please push in a few days if no additional comments are posted.