From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: ttn@gnu.org, 24317@debbugs.gnu.org, schwab@linux-m68k.org
Subject: bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix
Date: Sun, 28 Aug 2016 17:31:22 +0300 [thread overview]
Message-ID: <831t19c6dh.fsf@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1608282124270.7961@calancha-pc> (message from Tino Calancha on Sun, 28 Aug 2016 21:26:23 +0900 (JST))
> > I think we should indeed use image-type instead of having yet another
> > function that recognizes JPEG. The problem I pointed out should be
> > fixed in image-type-from-file-name, regardless.
> I see. I have prepared following new patch:
>
> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
> >From b953d600a295e4e0aa58b85126296663e7f02472 Mon Sep 17 00:00:00 2001
> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Sun, 28 Aug 2016 21:20:22 +0900
> Subject: [PATCH] image-type-from-file-name: Perform a case insensitive
> match
>
> Fix Bug#24317
> * lisp/image.el (image-type-from-file-name): Bind case-fold-search
> to a non-nil value to force a case insensitive match.
> * lisp/image-dired.el (image-dired-rotate-original):
> Use image-type (Bug#24317).
> (image-dired-get-exif-file-name): Idem.
> Set 'no-exif-data-found' and 'data' in same setq call.
> Use file-attribute-modification-time.
Thanks, this looks good to me. Please push in a few days if no
additional comments are posted.
next prev parent reply other threads:[~2016-08-28 14:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 8:04 bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix Tino Calancha
2016-08-27 8:21 ` Eli Zaretskii
2016-08-27 8:53 ` Tino Calancha
2016-08-27 8:57 ` Eli Zaretskii
2016-08-27 9:21 ` Tino Calancha
2016-08-27 9:27 ` Tino Calancha
2016-08-27 9:42 ` Thien-Thi Nguyen
2016-08-27 11:28 ` Eli Zaretskii
2016-08-27 12:18 ` Tino Calancha
2016-08-27 12:55 ` Eli Zaretskii
2016-08-28 12:26 ` Tino Calancha
2016-08-28 14:31 ` Eli Zaretskii [this message]
2016-08-28 14:49 ` Tino Calancha
2016-09-04 2:19 ` Tino Calancha
2016-08-28 6:22 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831t19c6dh.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=24317@debbugs.gnu.org \
--cc=schwab@linux-m68k.org \
--cc=tino.calancha@gmail.com \
--cc=ttn@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).