From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21391: 24.5; `thing-at-point' should return a string Date: Mon, 07 Nov 2016 20:04:22 +0200 Message-ID: <831syni2u1.fsf@gnu.org> References: < <0a68c2ae-0940-4e2c-8b3c-1faceb45c43c@default> <1773ab35-70b1-42f9-8a8b-fe07881487d1@default>> <<874m3krnb6.fsf_-_@gmail.com>> <<83a8dbiaps.fsf@gnu.org>> <123efdfd-3a87-4b39-9567-a56ecc3ea82e@default> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1478542079 16030 195.159.176.226 (7 Nov 2016 18:07:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 7 Nov 2016 18:07:59 +0000 (UTC) Cc: tino.calancha@gmail.com, 21391@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 07 19:07:55 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3oKa-000229-R1 for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Nov 2016 19:07:40 +0100 Original-Received: from localhost ([::1]:55739 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3oKd-0001RT-SR for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Nov 2016 13:07:43 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3oI7-00085u-2o for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2016 13:05:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3oI2-00042g-MV for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2016 13:05:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33242) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c3oI2-00042b-Ib for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2016 13:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c3oI2-0002dk-9Y for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2016 13:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Nov 2016 18:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21391 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21391-submit@debbugs.gnu.org id=B21391.147854184310079 (code B ref 21391); Mon, 07 Nov 2016 18:05:02 +0000 Original-Received: (at 21391) by debbugs.gnu.org; 7 Nov 2016 18:04:03 +0000 Original-Received: from localhost ([127.0.0.1]:48641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3oH4-0002cV-V4 for submit@debbugs.gnu.org; Mon, 07 Nov 2016 13:04:03 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:38215) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3oH3-0002c2-BJ for 21391@debbugs.gnu.org; Mon, 07 Nov 2016 13:04:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3oGt-00031S-VF for 21391@debbugs.gnu.org; Mon, 07 Nov 2016 13:03:56 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3oGt-00031K-Sj; Mon, 07 Nov 2016 13:03:51 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2179 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c3oGs-000831-W1; Mon, 07 Nov 2016 13:03:51 -0500 In-reply-to: <123efdfd-3a87-4b39-9567-a56ecc3ea82e@default> (message from Drew Adams on Mon, 7 Nov 2016 08:10:34 -0800 (PST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125430 Archived-At: > Date: Mon, 7 Nov 2016 08:10:34 -0800 (PST) > From: Drew Adams > Cc: 21391@debbugs.gnu.org, drew.adams@oracle.com > > What is new (since Emacs 24.4) is that someone added this at the end > of the definition of `thing-at-point', and made it pertain to _both_ > branches of the `if'. In addition, they named the result of the `if' > by the variable `text'. > > (when (and text no-properties) > (set-text-properties 0 (length text) nil text)) > > They apparently paid no attention to the important `thing-at-point' > behavior provided by the first `if' clause, and instead just assumed > that the `if' always returned a string. This is already fixed in the current sources. We now only remove the text properties if the object supports that. Why isn't that enough?