From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode) Date: Mon, 13 Nov 2017 17:51:23 +0200 Message-ID: <831sl2mb2c.fsf@gnu.org> References: <87y3nka4ez.fsf@t-online.de> <87wp34a2i1.fsf@t-online.de> <83y3njs8i1.fsf@gnu.org> <878tfjnkwg.fsf@t-online.de> <834lq1p455.fsf@gnu.org> <87tvxz3nv1.fsf@gmail.com> <83tvxzn3tr.fsf@gnu.org> <878tfbdp3a.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1510588341 4622 195.159.176.226 (13 Nov 2017 15:52:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 13 Nov 2017 15:52:21 +0000 (UTC) Cc: olaf.rogalsky@t-online.de, 29150@debbugs.gnu.org To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 13 16:52:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEH1w-0000ed-8t for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 Nov 2017 16:52:12 +0100 Original-Received: from localhost ([::1]:55081 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEH21-0000yS-HW for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 Nov 2017 10:52:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEH1p-0000w1-R1 for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2017 10:52:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eEH1m-00045k-Lk for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2017 10:52:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58293) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eEH1m-00044m-Hg for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2017 10:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eEH1l-0000Wn-VP for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2017 10:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Nov 2017 15:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29150 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29150-submit@debbugs.gnu.org id=B29150.15105882871986 (code B ref 29150); Mon, 13 Nov 2017 15:52:01 +0000 Original-Received: (at 29150) by debbugs.gnu.org; 13 Nov 2017 15:51:27 +0000 Original-Received: from localhost ([127.0.0.1]:38741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEH1D-0000Vy-JR for submit@debbugs.gnu.org; Mon, 13 Nov 2017 10:51:27 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:59863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eEH1B-0000Vl-Eh for 29150@debbugs.gnu.org; Mon, 13 Nov 2017 10:51:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eEH12-0003Vt-GM for 29150@debbugs.gnu.org; Mon, 13 Nov 2017 10:51:20 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEH12-0003Vf-Do; Mon, 13 Nov 2017 10:51:16 -0500 Original-Received: from [176.228.60.248] (port=1666 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eEH11-000803-TS; Mon, 13 Nov 2017 10:51:16 -0500 In-reply-to: <878tfbdp3a.fsf@gmail.com> (message from Alex on Sun, 12 Nov 2017 18:00:57 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139831 Archived-At: > From: Alex > Cc: olaf.rogalsky@t-online.de, 29150@debbugs.gnu.org > Date: Sun, 12 Nov 2017 18:00:57 -0600 > > >> Perhaps the patch should be replaced on the master branch with one that > >> uses `read-key' in all cases? > > > > Why the rush? > > I don't mean to rush anything, but I figured that I should mention it > before I forget about it. The thing is, I'm not yet sure read-key is TRT in this case. We have a lousy record in our changes of input processing code: almost every change caused subtle bugs that took many moons to find and fix. I think we should recognize this vulnerability and behave more cautiously. > > If you want this on the release branch, it should be affect only > > xt-mouse. If you propose this for master, see above. > > Do you mean that I shouldn't rush the `read-key' change for > `mouse-drag-secondary' in master, either? I'd like first to see how it fares on the release branch (and on master), when it is limited to xt-mouse. > Would applying the previous diff for master and the following for > emacs-26 be acceptable? Looks OK for the release branch (from which it will be merged to master). I'd prefer to wait with a more radical change even on master. Maybe put a FIXME comment there, to the effect that we should try removing the condition at some point. Thanks.