From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31763: 26.1; Unable to visit git revision in compact-style vc log buffer Date: Sun, 10 Jun 2018 19:52:29 +0300 Message-ID: <831sdeshwy.fsf@gnu.org> References: <87y3fpf63n.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1528649470 19285 195.159.176.226 (10 Jun 2018 16:51:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 10 Jun 2018 16:51:10 +0000 (UTC) Cc: 31763@debbugs.gnu.org To: Carlos Pita Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 10 18:51:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fS3YV-0004uC-Gh for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Jun 2018 18:51:03 +0200 Original-Received: from localhost ([::1]:44699 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fS3ac-0001CG-KW for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Jun 2018 12:53:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50753) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fS3aT-0001Bw-Pr for bug-gnu-emacs@gnu.org; Sun, 10 Jun 2018 12:53:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fS3aQ-0006XJ-Le for bug-gnu-emacs@gnu.org; Sun, 10 Jun 2018 12:53:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34610) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fS3aQ-0006X6-HU for bug-gnu-emacs@gnu.org; Sun, 10 Jun 2018 12:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fS3aQ-000792-8l for bug-gnu-emacs@gnu.org; Sun, 10 Jun 2018 12:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jun 2018 16:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31763 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31763-submit@debbugs.gnu.org id=B31763.152864955527429 (code B ref 31763); Sun, 10 Jun 2018 16:53:02 +0000 Original-Received: (at 31763) by debbugs.gnu.org; 10 Jun 2018 16:52:35 +0000 Original-Received: from localhost ([127.0.0.1]:42507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fS3Zz-00078L-EF for submit@debbugs.gnu.org; Sun, 10 Jun 2018 12:52:35 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fS3Zx-000789-Mn for 31763@debbugs.gnu.org; Sun, 10 Jun 2018 12:52:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fS3Zp-00068F-Cq for 31763@debbugs.gnu.org; Sun, 10 Jun 2018 12:52:28 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fS3Zp-000684-8t; Sun, 10 Jun 2018 12:52:25 -0400 Original-Received: from [176.228.60.248] (port=4491 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fS3Zo-0007tU-FU; Sun, 10 Jun 2018 12:52:24 -0400 In-reply-to: <87y3fpf63n.fsf@gmail.com> (message from Carlos Pita on Fri, 08 Jun 2018 16:09:16 -0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147266 Archived-At: > From: Carlos Pita > Date: Fri, 08 Jun 2018 16:09:16 -0300 > > I created a test git repo, add a file, make a few changes, commit a few > revisions. Now I open the compact log buffer for the file (C-x v L) and > when I try to visit a revision (f) I get, for instance: > > Checking out /tmp/repo/.~69ad211~... > vc-find-backend-function: Cannot open load file: No such file or directory, vc-nil Invoking 'f' from the log shown by "C-x v L" (and also "C-x v b") makes no sense: one cannot "visit the version" except in the context of a specific file or a set of files. And "C-x v L" is not about a file, it's about the whole tree. Without a specific file, log-view-find-revision cannot show anything sensible, even if we fix the vc-nil problem. Btw, it looks like this command never worked from these two varieties of log buffers. My suggestion is to bind 'f' in these two kinds of listings to a different command, which would ask the user what file to show at that revision.