From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32676: Feature request Date: Thu, 13 Sep 2018 19:44:04 +0300 Message-ID: <831s9xl54b.fsf@gnu.org> References: <20180910050802.25922-1-erjoalgo@gmail.com> <83a7ollcq2.fsf@gnu.org> <874let1o3k.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1536856988 9211 195.159.176.226 (13 Sep 2018 16:43:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 13 Sep 2018 16:43:08 +0000 (UTC) Cc: rpluim@gmail.com, 32676@debbugs.gnu.org To: Ernesto Alfonso Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 13 18:43:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0Uhq-0002Df-GB for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Sep 2018 18:43:02 +0200 Original-Received: from localhost ([::1]:43454 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g0Ujx-00068E-39 for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Sep 2018 12:45:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g0Ujq-000684-3p for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2018 12:45:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g0Ujm-0008F1-G6 for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2018 12:45:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35185) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g0Ujm-0008En-BV for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2018 12:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g0Ujm-0002JK-84 for bug-gnu-emacs@gnu.org; Thu, 13 Sep 2018 12:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Sep 2018 16:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32676-submit@debbugs.gnu.org id=B32676.15368570738819 (code B ref 32676); Thu, 13 Sep 2018 16:45:02 +0000 Original-Received: (at 32676) by debbugs.gnu.org; 13 Sep 2018 16:44:33 +0000 Original-Received: from localhost ([127.0.0.1]:39443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0UjJ-0002IA-7q for submit@debbugs.gnu.org; Thu, 13 Sep 2018 12:44:33 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0UjI-0002Hy-2l for 32676@debbugs.gnu.org; Thu, 13 Sep 2018 12:44:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g0Uj7-0007l3-9T for 32676@debbugs.gnu.org; Thu, 13 Sep 2018 12:44:26 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g0Uj7-0007ks-4G; Thu, 13 Sep 2018 12:44:21 -0400 Original-Received: from [176.228.60.248] (port=4092 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g0Uj6-0002ti-1o; Thu, 13 Sep 2018 12:44:21 -0400 In-reply-to: (message from Ernesto Alfonso on Thu, 13 Sep 2018 08:02:48 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150294 Archived-At: > From: Ernesto Alfonso > Date: Thu, 13 Sep 2018 08:02:48 -0700 > Cc: Eli Zaretskii , 32676@debbugs.gnu.org > > The problem is that there are two independent* markers, point, and a marker at the beginning of the current > error line in the next error buffer, for example compilation-current-error, where the fringe arrow is displayed. > > In the same way that the user can move around the point in the next-error buffer between calls to > {next,previous}-error without affecting the location of the fringe arrow, the user should also be able to move > point around without affecting highlighting of the current error message (for example, to kill part of an error > message in the compilation buffer), since this is really a visual enhancement to the fringe arrow. You should be able to fix this problem by setting hl-line-range-function to a suitable function (which should be quite simple, AFAIU). > Another problem with hl-line is what the original poster pointed out in the screenshot below: hl-line only > highlights on the current buffer's window, so if the user were to switch to the source code buffer (or if he > wasn't there in the first place, e.g. by having invokied next-error form the source code buffer via a key > binding) then highlighting of error messages is either lost or never happens. This is only true for the global-hl-line-mode; the local mode's highlight is "sticky" by default, and shows even in non-selected windows. Moreover, you can customize the global mode so that its highlight is sticky as well (not that I see why would you want to in this case). > Basically, the difference is that hl-line uses post-command-hooks to track the current line and put an overlay > on it, whereas in this case highlighting only changes whenever next-error-hook is invoked. Is this really important? Those are just implementation details, no?