unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 33650@debbugs.gnu.org
Subject: bug#33650: 27.0.50; Root diffs between revisions
Date: Fri, 07 Dec 2018 08:41:44 +0200	[thread overview]
Message-ID: <831s6t7s9j.fsf@gnu.org> (raw)
In-Reply-To: <87d0qe8gon.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 06 Dec 2018 23:54:16 +0200)

> From: Juri Linkov <juri@linkov.net>
> Date: Thu, 06 Dec 2018 23:54:16 +0200
> 
> This patch fixes this omission by implementing `vc-root-version-diff'
> that is able to compare two revisions even on separate branches from
> their roots:

Thanks.  A few comments:

> +(defun vc-root-version-diff (_files rev1 rev2)
> +  "Report diffs between revisions of the whole tree in the repository history."

This doc string doesn't describe the arguments, and doesn't tell how
those arguments are populated in interactive invocations.

I also wonder what would this mean for a VCS such as CVS or RCS, where
there's no meaning of a "tree revision".  I'm guessing this is why the
old code deduced files to diff.  See also the description of vc-diff
in the Emacs manual.

Finally, we need documentation changes to go with this change of
user-visible behavior.





  reply	other threads:[~2018-12-07  6:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-06 21:54 bug#33650: 27.0.50; Root diffs between revisions Juri Linkov
2018-12-07  6:41 ` Eli Zaretskii [this message]
2018-12-08 23:32   ` Juri Linkov
2018-12-09  8:22     ` Eli Zaretskii
2018-12-10  0:04       ` Juri Linkov
2018-12-10  0:59         ` Dmitry Gutov
2018-12-10  6:30           ` Eli Zaretskii
2018-12-10 23:55           ` Juri Linkov
2018-12-10  6:29         ` Eli Zaretskii
2018-12-10 23:55           ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831s6t7s9j.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=33650@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).