unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 35498-done@debbugs.gnu.org
Subject: bug#35498: 26.2; doc string of `isearch-regexp-function'
Date: Fri, 03 May 2019 12:24:15 +0300	[thread overview]
Message-ID: <831s1fopq8.fsf@gnu.org> (raw)
In-Reply-To: <95f9cdd4-4d43-458e-8354-dfc8972b14bf@default> (message from Drew Adams on Mon, 29 Apr 2019 18:48:48 -0700 (PDT))

> Date: Mon, 29 Apr 2019 18:48:48 -0700 (PDT)
> From: Drew Adams <drew.adams@oracle.com>
> 
> The doc string should describe the possible values and their
> meanings/behaviors.  Currently it describes only a function as value.

I added the existing functions that could be used as values.  Their
descriptions are available by using the hyperlink, so no need to
duplicate that here.  The list is, of course, not exhaustive, as Lisp
programs could define their own functions.

> Searching isearch.el it seems that this variable can be any of the
> values possible for `search-default-mode'.  Please describe each of the
> values for `isearch-regexp-function'.

See above: not needed.

> Even when the value is a function the description could be better,
> saying that it must accept a string as its first arg and must return a
> string.  That can be surmised from saying that it converts a plain
> search string to a regexp [search string], but it could be clearer.

Added.

> Also, "plain search string" and "regexp" are unclear here.  The
> distinction is presumably (?) that the former contains no regexp special
> chars?  Or does the return value need to be a _valid_ (complete) regexp,
> and does the function raise an error if that's not possible?

I didn't see any problem here, although I improved the wording to some
extent.

Thanks.





  reply	other threads:[~2019-05-03  9:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30  1:48 bug#35498: 26.2; doc string of `isearch-regexp-function' Drew Adams
2019-05-03  9:24 ` Eli Zaretskii [this message]
     [not found] <<95f9cdd4-4d43-458e-8354-dfc8972b14bf@default>
     [not found] ` <<831s1fopq8.fsf@gnu.org>
2019-05-03 14:47   ` Drew Adams
2019-05-03 15:06     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831s1fopq8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=35498-done@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).