From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36550: mouse-face overlay calculation error Date: Sat, 13 Jul 2019 09:15:35 +0300 Message-ID: <831ryu31fc.fsf@gnu.org> References: <87v9wc2t8p.fsf@mouse.gnus.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="151405"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36550@debbugs.gnu.org, linus.kallberg@outlook.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 13 08:16:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmBKL-000dG6-EA for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Jul 2019 08:16:09 +0200 Original-Received: from localhost ([::1]:53800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmBKK-0006ff-32 for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Jul 2019 02:16:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34408) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmBKG-0006fY-1U for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 02:16:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmBKE-0002wk-0x for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 02:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60758) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hmBKD-0002we-U2 for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 02:16:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hmBKD-0001RI-Lv for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2019 02:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jul 2019 06:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36550 X-GNU-PR-Package: emacs Original-Received: via spool by 36550-submit@debbugs.gnu.org id=B36550.15629985515494 (code B ref 36550); Sat, 13 Jul 2019 06:16:01 +0000 Original-Received: (at 36550) by debbugs.gnu.org; 13 Jul 2019 06:15:51 +0000 Original-Received: from localhost ([127.0.0.1]:41346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmBK3-0001QX-5M for submit@debbugs.gnu.org; Sat, 13 Jul 2019 02:15:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmBK0-0001QG-P8 for 36550@debbugs.gnu.org; Sat, 13 Jul 2019 02:15:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57379) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hmBJv-0002hd-7b; Sat, 13 Jul 2019 02:15:43 -0400 Original-Received: from [176.228.60.248] (port=2214 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hmBJu-0001AF-N7; Sat, 13 Jul 2019 02:15:43 -0400 In-reply-to: (message from Lars Ingebrigtsen on Sat, 13 Jul 2019 02:31:15 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162849 Archived-At: > From: Lars Ingebrigtsen > Date: Sat, 13 Jul 2019 02:31:15 +0200 > Cc: "36550@debbugs.gnu.org" <36550@debbugs.gnu.org> > > (progn > (let ((point (point))) > (insert "foo\n") > (let ((o (make-overlay point (point)))) > (overlay-put o 'mouse-face 'highlight) > (insert "bar")))) > > This should make a mouse face that's displayed the entire "foo" line, > but it extends to the first character of the next line. > > If you make it one character shorter, then the entire line isn't > highlighted. > > And! If you say `face' instead of `mouse-face', then everything is > highlighted correctly (i.e., just the entire "foo" line, and not the "b" > on the next line). Mouse-face isn't supposed to cover newlines, I think. Why do you need that? The "one character shorter" variant does what it's expected to do, because mouse-face is not extended to EOL as with other faces. Mouse-face is for showing the parts of text that are mouse-sensitive, so it makes no sense to highlight portions of display that have no text. > So is there some basic fault in the code that calculates the length of > the mouse highlighting? I don't really know where to start looking... It's in the display code, and is quite complicated due to bidirectional text use case. See mouse_face_from_buffer_pos and its subroutine rows_from_pos_range.