From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36834: 27.0.50; [PATCH] password-cache.el: confuses key absence with nil password Date: Sat, 10 Aug 2019 11:19:01 +0300 Message-ID: <831rxta0wa.fsf@gnu.org> References: <875znltof0.fsf@telefonica.net> <87v9vlck5a.fsf@tcd.ie> <87wog1rkte.fsf@telefonica.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="165893"; mail-complaints-to="usenet@blaine.gmane.org" Cc: contovob@tcd.ie, monnier@iro.umontreal.ca, 36834@debbugs.gnu.org To: =?UTF-8?Q?=C3=93scar?= Fuentes Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 10 10:20:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hwMbg-000h1h-S4 for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Aug 2019 10:20:08 +0200 Original-Received: from localhost ([::1]:35348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hwMbf-0003Zd-Uo for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Aug 2019 04:20:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56526) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hwMbb-0003Sy-Uu for bug-gnu-emacs@gnu.org; Sat, 10 Aug 2019 04:20:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hwMba-00067u-Vp for bug-gnu-emacs@gnu.org; Sat, 10 Aug 2019 04:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34595) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hwMba-00067k-SY for bug-gnu-emacs@gnu.org; Sat, 10 Aug 2019 04:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hwMba-00053r-LT for bug-gnu-emacs@gnu.org; Sat, 10 Aug 2019 04:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Aug 2019 08:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36834 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36834-submit@debbugs.gnu.org id=B36834.156542515419393 (code B ref 36834); Sat, 10 Aug 2019 08:20:02 +0000 Original-Received: (at 36834) by debbugs.gnu.org; 10 Aug 2019 08:19:14 +0000 Original-Received: from localhost ([127.0.0.1]:43416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hwMao-00052j-DQ for submit@debbugs.gnu.org; Sat, 10 Aug 2019 04:19:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hwMam-00052S-5T for 36834@debbugs.gnu.org; Sat, 10 Aug 2019 04:19:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hwMag-0005gr-Bm; Sat, 10 Aug 2019 04:19:06 -0400 Original-Received: from [176.228.60.248] (port=3804 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hwMaf-0002oy-SE; Sat, 10 Aug 2019 04:19:06 -0400 In-reply-to: <87wog1rkte.fsf@telefonica.net> (message from =?UTF-8?Q?=C3=93scar?= Fuentes on Mon, 29 Jul 2019 16:12:45 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164823 Archived-At: Ping! Any followups? Stefan? Should we just push this? > From: Óscar Fuentes > Date: Mon, 29 Jul 2019 16:12:45 +0200 > Cc: Stefan Monnier , 36834@debbugs.gnu.org > > "Basil L. Contovounesios" writes: > > >> The change uses gethash instead of intern-soft, but those functions act > >> differently when the password (the value associated with the key) was > >> nil. > > > > Is it valid for the password to be nil? The logic in password-read > > suggests otherwise. > > Callers are sending nil. If it is not valid, there is a problem > elsewhere, but my understanding is that a nil password means "no > password" and it is cached in the memoization sense. > > >> The effect is that every call to password-cache-add with nil as > >> password creates a new timer, > > > > Where is password-cache-add being passed a nil password? > > The caller is auth-source-remember, IIRC, which itself is called from > auth-source-search. Can you show a reproducer?