unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 30085@debbugs.gnu.org, boruch_baum@gmx.com, storm@cua.dk
Subject: bug#30085: 25.2: Documentation for cua-rectangle-mark-mode
Date: Sat, 19 Oct 2019 09:39:57 +0300	[thread overview]
Message-ID: <831rv98chu.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmkustpq0sKD0sQEX9fAZsQ=zfZhoOXHcTbn7vCQBRzfBQ@mail.gmail.com> (message from Stefan Kangas on Sat, 19 Oct 2019 03:21:52 +0200)

> From: Stefan Kangas <stefan@marxist.se>
> Date: Sat, 19 Oct 2019 03:21:52 +0200
> Cc: Eli Zaretskii <eliz@gnu.org>, 30085@debbugs.gnu.org, Kim Storm <storm@cua.dk>
> 
> Boruch Baum <boruch_baum@gmx.com> writes:
> 
> > I had some time to look at the pacakge, and produced some notes and a
> > patch file, before realizing that it would be a good idea to consult
> > with you both before continuing and possibly wasting a lot of my
> > volunteer time-budget.
> 
> That was in March 2018, but it seems like you unfortunately never got a
> reply here.  Are you still working on this?  Could you send the patch
> you wrote?

If Kim doesn't respond, as he didn't back then, I suggest you use your
best judgment to retain whatever seems useful from this patch.

Internal functions indeed don't need to be documented, but if the doc
string makes a significant difference in how easy it is to understand
what the function does, including a doc string can only help future
maintenance.

I know very little about cua-rectangle-mode, mainly around the tricks
it plays with the display code (and the special support these tricks
have in the display engine), so I cannot answer the questions that
Boruch asked.

Thanks.





  reply	other threads:[~2019-10-19  6:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12  7:14 bug#30085: 25.2: Documentation for cua-rectangle-mark-mode Boruch Baum
2018-01-12  9:22 ` Eli Zaretskii
2018-01-12 11:00   ` Kim Storm
2018-01-12 18:53     ` Eli Zaretskii
2018-01-26 18:57       ` Boruch Baum
2018-03-21 12:48       ` Boruch Baum
2020-10-27  1:50         ` Stefan Kangas
2020-10-28  6:40           ` Boruch Baum
2020-12-16  7:43           ` Boruch Baum
2018-01-12 11:06   ` Kim Storm
2019-10-19  1:21 ` Stefan Kangas
2019-10-19  6:39   ` Eli Zaretskii [this message]
2020-10-27  1:39     ` Stefan Kangas
2019-10-23 10:56   ` Boruch Baum
2019-10-23 11:10     ` Stefan Kangas
2019-10-28 10:41       ` Lars Ingebrigtsen
2019-10-28 16:11         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831rv98chu.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=30085@debbugs.gnu.org \
    --cc=boruch_baum@gmx.com \
    --cc=stefan@marxist.se \
    --cc=storm@cua.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).