From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37806: 27.0.50; Need to "extend" face-remap.el Date: Mon, 21 Oct 2019 10:20:00 +0300 Message-ID: <831rv64lb3.fsf@gnu.org> References: <875zkmmn4u.fsf@gmx.net> <835zkk7i8i.fsf@gnu.org> <87r237txnl.fsf@gmx.net> <20191020143930.ugxiakrap7yym6qw@Ergus> <8336fn5uf8.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="181880"; mail-complaints-to="usenet@blaine.gmane.org" Cc: stephen.berman@gmx.net, 37806@debbugs.gnu.org To: spacibba@aol.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 21 09:21:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iMS0D-000l8n-37 for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Oct 2019 09:21:17 +0200 Original-Received: from localhost ([::1]:35410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMS0B-0005FV-Li for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Oct 2019 03:21:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47376) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMRzz-0005FK-82 for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 03:21:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMRzy-0006Qx-9R for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 03:21:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46831) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMRzy-0006Qm-27 for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 03:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iMRzx-0005OX-Sg for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 03:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Oct 2019 07:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37806 X-GNU-PR-Package: emacs Original-Received: via spool by 37806-submit@debbugs.gnu.org id=B37806.157164241320652 (code B ref 37806); Mon, 21 Oct 2019 07:21:01 +0000 Original-Received: (at 37806) by debbugs.gnu.org; 21 Oct 2019 07:20:13 +0000 Original-Received: from localhost ([127.0.0.1]:55652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMRzB-0005N2-E5 for submit@debbugs.gnu.org; Mon, 21 Oct 2019 03:20:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMRz9-0005Mm-SZ for 37806@debbugs.gnu.org; Mon, 21 Oct 2019 03:20:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:32815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iMRz4-00068M-OL; Mon, 21 Oct 2019 03:20:06 -0400 Original-Received: from [176.228.60.248] (port=1871 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iMRz3-0006nE-UD; Mon, 21 Oct 2019 03:20:06 -0400 In-reply-to: <8336fn5uf8.fsf@gnu.org> (message from Eli Zaretskii on Sun, 20 Oct 2019 18:05:31 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169886 Archived-At: > Date: Sun, 20 Oct 2019 18:05:31 +0300 > From: Eli Zaretskii > Cc: stephen.berman@gmx.net, 37806@debbugs.gnu.org > > > Date: Sun, 20 Oct 2019 16:39:30 +0200 > > From: Ergus > > Cc: Eli Zaretskii , 37806@debbugs.gnu.org > > > > The proper fix must be to declare the vector in the C side using the > > real symbols like: > > > > Lisp_Object internal-lisp-face-attributes[LFACE_VECTOR_SIZE] = { > > Qnil QCfamily, QCfoundry, QCwidth QCheight, > > QCweight, QCslant, QCunderline, QCinverse_video, > > QCforeground, QCbackground, QCstipple, QCoverline, > > QCstrike_through, QCbox, QCfont, QCinherit, QCfontset, > > QCdistant_foreground, QCextend > > }; > > > > But using makevector or a similar api from C. > > Yes, and face-remap.el even says so. > > You can "steal" the way this is done from coding.c, starting around > line 11635 (but there should be no need to staticpro a variable that > is visible from Lisp, unlike Vcoding_category_table). > > > So I will submit the simplest fix now and if Eli gives me a green light > > I will implement the better version. Jimmy, in case it was unclear, my comments above is the "green light" you asked for implementing a better version in xfaces.c. We should have done that cleanup long ago, IMO. Thanks.