From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Wed, 23 Oct 2019 21:04:08 +0300 Message-ID: <831rv3z6cn.fsf@gnu.org> References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <87k194fvn7.fsf@mail.linkov.net> <871rvceeqp.fsf@mail.linkov.net> <83tv88cyic.fsf@gnu.org> <83pniwcvon.fsf@gnu.org> <87pniw30td.fsf@mail.linkov.net> <4dc05091-53db-bff9-4623-0aedd9c2907f@gmx.at> <6f01b03d-7be3-71cc-ff97-c1a4f7b3c213@yandex.ru> <83tv879vy0.fsf@gnu.org> <6bc27f9f-e701-afb8-c6f1-408f471187c7@yandex.ru> <83imon9tg3.fsf@gnu.org> <5db11c91-a216-40f6-f4c2-7b10c73532cc@yandex.ru> <83h8424ojp.fsf@gnu.org> <9fbdd8e8-4f6a-1aba-6509-d2699c82373b@yandex.ru> <83k18vzd1j.fsf@gnu.org> <3919a409-1a2b-8da6-a1d0-f9f6def09dfe@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="127588"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37774@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 23 23:24:48 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iNO7c-000X2T-21 for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Oct 2019 23:24:48 +0200 Original-Received: from localhost ([::1]:48204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNO7a-0003aP-BU for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Oct 2019 17:24:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36029) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNL0P-0003e9-0E for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 14:05:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNL0K-000144-KH for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 14:05:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54393) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iNL0I-00013l-OE for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 14:05:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iNL0I-0000EI-FV for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 14:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Oct 2019 18:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.1571853874846 (code B ref 37774); Wed, 23 Oct 2019 18:05:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 23 Oct 2019 18:04:34 +0000 Original-Received: from localhost ([127.0.0.1]:34981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNKzq-0000Da-Aj for submit@debbugs.gnu.org; Wed, 23 Oct 2019 14:04:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNKzo-0000DO-7j for 37774@debbugs.gnu.org; Wed, 23 Oct 2019 14:04:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57345) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iNKzi-0000li-OJ; Wed, 23 Oct 2019 14:04:26 -0400 Original-Received: from [176.228.60.248] (port=2990 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iNKzi-0004vP-1u; Wed, 23 Oct 2019 14:04:26 -0400 In-reply-to: <3919a409-1a2b-8da6-a1d0-f9f6def09dfe@yandex.ru> (message from Dmitry Gutov on Wed, 23 Oct 2019 19:12:26 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170096 Archived-At: > Cc: 37774@debbugs.gnu.org > From: Dmitry Gutov > Date: Wed, 23 Oct 2019 19:12:26 +0300 > > >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=37774#233 > > > > AFAIU, that's a list of faces one particular user decided to customize > > to have them extended. It's a far cry from the list of faces that > > actually need to be extended, lest some important functionality will > > suffer. IOW, we need some rationale for each face, so that we could > > consider that and decide whether or not to extend each one by default. > > Magit's maintainer will decide for each face, sure. I don't mind if package maintainers want to make that decision by themselves, but if that is the case, I don't think there's anything left to do for this bug report? I though some action will be required from us, that's why I asked all those questions. > But I don't really see much a difference between having 2 and 20 faces > that will need to be updated, if it's within one package. It's a difference between a small number and a very large number. Theoretically, someone could argue that a change that requires to modify lots of faces shouldn't be so unconditional, or shouldn't be the default, or should have a "fire escape", or something to that effect. But if people don't mind changing their faces, then such fears have no basis, and we are good with what we have. > Even if it's just 2, do we have a recommended way to write their > definitions in third-party packages in a way that's compatible with > Emacs 26? The best way is to inherit from some suitable parent face, I think. > > If too many faces in unbundled packages indeed need to change in that > > way, we should consider additional measures. That's why we need good > > reasons for extending each face, not just "because they were before" > > or because people were used to see them extended. > > Those are not the worst reasons, though. Not sure I understand in what sens did you use "the worst" here.