From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11339: 24.1.50; read-{buffer,file-name}-completion-ignore-case fails on non-ascii Date: Wed, 06 Nov 2019 18:58:36 +0200 Message-ID: <831rulgcw3.fsf@gnu.org> References: <87ehrbyg8t.fsf@escher.home> <87lfszxtcl.fsf@marxist.se> <83bltvl55x.fsf@gnu.org> <87o8xvz0hp.fsf@gmx.net> <83tv7mkb0l.fsf@gnu.org> <87d0ea9uxg.fsf@gmx.net> <83eeyphr5q.fsf@gnu.org> <87lfsvyd4i.fsf@gmx.net> <87h83jy5kp.fsf@gmx.net> <83v9rzh8gs.fsf@gnu.org> <875zjzy0yg.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="253222"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 11339@debbugs.gnu.org, stefan@marxist.se To: Stephen Berman , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 06 18:00:35 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iSOfa-0013kV-WB for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Nov 2019 18:00:35 +0100 Original-Received: from localhost ([::1]:33104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSOfY-00018j-TO for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Nov 2019 12:00:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40504) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSOf6-00016o-7J for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2019 12:00:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSOf4-00005w-KG for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2019 12:00:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60593) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iSOf4-00005o-Fg for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2019 12:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iSOf4-0003YW-B0 for bug-gnu-emacs@gnu.org; Wed, 06 Nov 2019 12:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Nov 2019 17:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11339 X-GNU-PR-Package: emacs Original-Received: via spool by 11339-submit@debbugs.gnu.org id=B11339.157305954213522 (code B ref 11339); Wed, 06 Nov 2019 17:00:02 +0000 Original-Received: (at 11339) by debbugs.gnu.org; 6 Nov 2019 16:59:02 +0000 Original-Received: from localhost ([127.0.0.1]:41181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSOe5-0003Vw-M4 for submit@debbugs.gnu.org; Wed, 06 Nov 2019 11:59:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iSOe3-0003VZ-7j for 11339@debbugs.gnu.org; Wed, 06 Nov 2019 11:58:59 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51811) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iSOdx-0007vF-Jd; Wed, 06 Nov 2019 11:58:53 -0500 Original-Received: from [176.228.60.248] (port=2494 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iSOdw-0000Qy-Db; Wed, 06 Nov 2019 11:58:53 -0500 In-reply-to: <875zjzy0yg.fsf@gmx.net> (message from Stephen Berman on Mon, 04 Nov 2019 19:02:15 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171034 Archived-At: > From: Stephen Berman > Cc: stefan@marxist.se, 11339@debbugs.gnu.org > Date: Mon, 04 Nov 2019 19:02:15 +0100 > > >> 1. $ emacs-master -Q --eval '(setq read-buffer-completion-ignore-case tread-file-name-completion-ignore-case t)' /tmp/{bah,bAh,bäh,bÄh} > >> (*Buffer List* show the buffers bah,bAh,bäh,bÄh) > >> 2. C-x b *scratch* > >> 3a. C-x b ba TAB > >> => completes to bah and after TAB displays [Sole completion] > >> 3b. C-g C-x b bA TAB > >> => completes to bAh and after TAB displays [Sole completion] > >> 4a. C-g C-x b bä TAB > >> => completes to bäh and after TAB displays [Sole completion] > >> 4b. C-g C-x b bÄ TAB > >> => completes to bÄh and after TAB displays [Sole completion] > >> 5a. C-g C-x C-f /tmp/ba TAB > >> => completes to bah and after TAB displays [Complete, but not unique] > >> and *Completions* pops up showing `bAh' and `bah' > >> 5b. C-g C-x C-f /tmp/bA TAB > >> => completes to bAh and after TAB displays [Complete, but not unique] > >> and *Completions* pops up showing `bAh' and `bah' > >> 6a. C-g C-x C-f /tmp/bä TAB > >> => completes to /tmp/bäh and after TAB displays [Complete, but not unique] > >> and *Completions* pops up showing `bAh' and `bah' > >> 6a. C-g C-x C-f /tmp/bÄ TAB > >> => completes to /tmp/bÄh and after TAB displays [Complete, but not unique] > >> and *Completions* pops up showing `bAh' and `bah' > >> > >> So, before your fix file name completion involving non-ASCII strings > >> behaved the same as buffer name completion involving both ASCII-only and > >> non-ASCII strings, but file name completion involving ASCII-only strings > >> differed. Now, after your fix, file name completion involving non-ASCII > >> strings works the same as file name completion involving ASCII-only > >> strings did before your fix and still does after, but all the cases of > >> file name completion differ from the corresponding cases of buffer name > >> completion. I would prefer buffer name completion to work the way file > >> name completion uniformly works after your fix. > > > > "You are in a maze of twisty little passages, all alike." > > > > (I'm confused by a dozen of similar examples which don't say which > > result is deemed to be correct and which isn't.) > > > > Previously, you said that buffer-name completion works correctly, > > I don't think so. In my OP of this bug I reported the results of `C-x > b' as incorrect (step 8 of the recipe there). In my followup a year > later, I reiterated that the "bug still exists" but added a different > observation of correct behavior involving `C-x b' but incorrect behavior > involving `C-x C-f'. After Stefan Kangas's post revisiting this bug, > which only looked at the `C-x b' behavior of my OP, you implied the > behavior is correct and said you see no bug, to which I replied with > what I intended to be a clarification of my OP, but it seems to have > confused you; my followup to that unfortunately seems to have added to > the confusion concerning the behavior of `C-x b', for which I apologize. > But I hope and think my last reply quoted above is clear: "all the cases > of file name completion differ from the corresponding cases of buffer > name completion. I would prefer buffer name completion to work the way > file name completion uniformly works after your fix." To phrase it in > terms of correctness: the results of `C-x b' in steps 3-4 quoted above > are incorrect; they should be the same as the results of `C-x C-f' in > steps 5-6, which are correct (IMO). I'm sorry, but someone else will have to dig into this. I tried, but got lost. I always do when I try to debug non-trivial issues with completion, what with the endless ping-pong of calls from minibuffer.el to minibuf.c and back, both directly and indirectly via variables whose values are functions. The best I could see (unless I'm mistaken) is that in the "C-x b" case the second TAB sees that the string in the minibuffer is a possible completion, and declares success; it doesn't call all-completions as I'd expect. If this observation is correct, then relying on try-completions in this case is what trips us, because try-completions has special heuristics when the candidates are all identical but for the letter-case, the result being that only one candidate is returned. CC'ing Stefan who might have a better idea of what is going on here.