From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36597: 27.0.50; rehash hash tables eagerly in pdumper Date: Tue, 11 Aug 2020 21:32:16 +0300 Message-ID: <831rkdowy7.fsf@gnu.org> References: <74235afc-7043-1da7-7c71-07f0ca23b9fd@cs.ucla.edu> <83r26mv53z.fsf@gnu.org> <87ft8vbow1.fsf@gnus.org> <87v9hq4ppp.fsf@gnus.org> <83k0y544lf.fsf@gnu.org> <835z9pp16x.fsf@gnu.org> <8525b631-b24e-ce89-6314-741449ca8403@cs.ucla.edu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36833"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 36597-done@debbugs.gnu.org, pipcet@gmail.com To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 11 20:34:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5Z6A-0009SY-Hb for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Aug 2020 20:34:10 +0200 Original-Received: from localhost ([::1]:60280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5Z69-0005HZ-HE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Aug 2020 14:34:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5Z54-0004a0-L6 for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 14:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58358) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5Z53-0007Gs-Vt for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 14:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k5Z53-00040G-TL for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 14:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Aug 2020 18:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36597-done@debbugs.gnu.org id=D36597.159717075515351 (code D ref 36597); Tue, 11 Aug 2020 18:33:01 +0000 Original-Received: (at 36597-done) by debbugs.gnu.org; 11 Aug 2020 18:32:35 +0000 Original-Received: from localhost ([127.0.0.1]:41671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5Z4d-0003zX-HH for submit@debbugs.gnu.org; Tue, 11 Aug 2020 14:32:35 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5Z4b-0003zJ-67 for 36597-done@debbugs.gnu.org; Tue, 11 Aug 2020 14:32:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47179) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5Z4V-0007DW-De; Tue, 11 Aug 2020 14:32:27 -0400 Original-Received: from [176.228.60.248] (port=3601 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k5Z4U-0000DM-Tm; Tue, 11 Aug 2020 14:32:27 -0400 In-Reply-To: <8525b631-b24e-ce89-6314-741449ca8403@cs.ucla.edu> (message from Paul Eggert on Tue, 11 Aug 2020 10:31:24 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184685 Archived-At: > Cc: larsi@gnus.org, 36597-done@debbugs.gnu.org > From: Paul Eggert > Date: Tue, 11 Aug 2020 10:31:24 -0700 > > The compilation issue was due to pdumper enabling -Wconversion, which causes > more trouble than it cures (but that is a different topic). I worked around the > glitch by installing the attached further patch, which should also help explain > the motivation for make_nil_vector. Is it really worth it? The code is now a kind of puzzle (what doe those ALLOW/DISALLOW_IMPLICIT_CONVERSION macros do?), and Fmake_vector is a very thin wrapper around the C function it calls. So I think this change is for the worse, sorry.