From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: larsi@gnus.org, 44471@debbugs.gnu.org
Subject: bug#44471: [PATCH] Simplify text-quoting-style
Date: Tue, 10 Nov 2020 18:12:31 +0200 [thread overview]
Message-ID: <831rh12ntc.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmk1=kxOSeOuRAmJuZ8zp-iDuGT+T0KDDXAG9vLAR5Q1Wg@mail.gmail.com> (message from Stefan Kangas on Mon, 9 Nov 2020 12:13:23 -0800)
> From: Stefan Kangas <stefan@marxist.se>
> Date: Mon, 9 Nov 2020 12:13:23 -0800
> Cc: 44471@debbugs.gnu.org
>
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
> > Stefan Kangas <stefan@marxist.se> writes:
> >
> >> I found an opportunity to simplify the code for text-quoting-style. See
> >> the attached patch.
> >>
> >> The patch also improves the name of the defun `get-quoting-style' by
> >> changing it to `text-quoting-style'. (This new name matches the old C
> >> function name and the existing variable name.)
> >>
> >> Any comments?
> >
> > Makes sense to me.
>
> Thanks. There have been no other comments, so I've pushed this to
> master as commit 95c04675ab.
Please in the future allow more than just a couple of days for people
to comment on non-trivial patches.
As it happens, I do have a few issues with the change:
. it slows down code of two very popular functions, because we now
use EQ instead of a C-level equality operator;
. it introduces a function that has the same name as a variable,
which adds a bit to confusion, and also defeats our method of
reporting in what version was the function/variable introduced
(try "C-h f"); and
. I don't think I see the simplification that justifies these
(admittedly quite minor) downsides
Thanks.
next prev parent reply other threads:[~2020-11-10 16:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 16:18 bug#44471: [PATCH] Simplify text-quoting-style Stefan Kangas
2020-11-09 15:56 ` Lars Ingebrigtsen
2020-11-09 20:13 ` Stefan Kangas
2020-11-10 14:30 ` Lars Ingebrigtsen
2020-11-10 16:12 ` Eli Zaretskii [this message]
2020-11-11 19:12 ` Stefan Kangas
2020-11-11 19:24 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831rh12ntc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=44471@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).