unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Philip K." <philipk@posteo.net>, martin rudalics <rudalics@gmx.at>
Cc: 45052@debbugs.gnu.org
Subject: bug#45052: 27.1; GDB completion moves point
Date: Sat, 05 Dec 2020 17:03:04 +0200	[thread overview]
Message-ID: <831rg4cn2v.fsf@gnu.org> (raw)
In-Reply-To: <87czzo71i6.fsf@posteo.net> (philipk@posteo.net)

> From: "Philip K." <philipk@posteo.net>
> Cc: 45052@debbugs.gnu.org
> Date: Sat, 05 Dec 2020 15:48:01 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> It seems to work, and I can't see any unintended side-effects!
> >
> > Thanks.  If you use gdb-mi.el a lot, how about if you run with this
> > change for a week and report back if you saw any adverse effects?
> > Then I'll install this if no problems are uncovered.
> 
> Will do. And thanks for finding the bug!

Not a bug, more like an unintended consequence.  The completion
machinery happens in this case to call the gdb-mi handlers for
processing responses to GDB commands, and those handlers force
redisplay to show the GUD window with the same window-start point,
which is impossible when the completions window pops up and point is
close to the bottom of the GUD window.  So I made the window-start
setting less forceful.  My fear is that when those handlers are called
in other situations, you will now see sub-optimal display after
sending GDB commands.  So please pay attention to any such effects on
the gdb-mi related windows.

If my "simple" solution has adverse effects, we will need to come up
with a more thorough one, which will likely require changes on the C
level.

Martin, do we have any way of preventing the original problem via
display-buffer actions, per chance?  I couldn't find anything to that
effect, FWIW.





  reply	other threads:[~2020-12-05 15:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-05 12:10 bug#45052: 27.1; GDB completion moves point Philip K.
2020-12-05 13:44 ` Eli Zaretskii
2020-12-05 14:01   ` Philip K.
2020-12-05 14:26     ` Eli Zaretskii
2020-12-05 14:48       ` Philip K.
2020-12-05 15:03         ` Eli Zaretskii [this message]
2020-12-05 15:21           ` martin rudalics
2020-12-05 16:01             ` Eli Zaretskii
2020-12-14  8:23       ` Philip K.
2020-12-14 18:10         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831rg4cn2v.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=45052@debbugs.gnu.org \
    --cc=philipk@posteo.net \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).