From: Eli Zaretskii <eliz@gnu.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 34765@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca,
alexanderm@web.de
Subject: bug#34765: 26.1; with-temp-buffer should not run buffer-list-update-hook
Date: Sat, 19 Dec 2020 12:33:36 +0200 [thread overview]
Message-ID: <831rfmultr.fsf@gnu.org> (raw)
In-Reply-To: <87eejnaqzz.fsf@tcd.ie> (contovob@tcd.ie)
> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Cc: Eli Zaretskii <eliz@gnu.org>, rudalics@gmx.at, larsi@gnus.org,
> 34765@debbugs.gnu.org, alexanderm@web.de
> Date: Fri, 18 Dec 2020 18:49:52 +0000
>
> * .dir-locals.el (c-mode): Enforce existing indent-tabs-mode policy.
This should be in a separate commit, IMO.
> +By default, undo information (@pxref{Undo}) is not recorded in the
> +buffer created by this macro (but @var{body} can enable that, if
> +needed). The temporary buffer also does not run the hooks
> +@code{kill-buffer-hook}, @code{kill-buffer-query-functions}
> +(@pxref{Killing Buffers}), and @code{buffer-list-update-hook}
> +(@pxref{Buffer List}).
It would be good to have here index entries about undo and those hooks
not being used by default in temporary buffers.
> +Like @code{with-temp-buffer} (@pxref{Definition of with-temp-buffer,,
^^^^^^^^^^
I think this word will look better if not capitalized.
> +static void
> +run_buffer_list_update_hook (struct buffer *buf)
> +{
> + if (! (NILP (Vrun_hooks) || (buf && buf->inhibit_buffer_hooks)))
^^^
Why this test? is it possible for this function to be called with buf
a NULL pointer?
Thanks.
next prev parent reply other threads:[~2020-12-19 10:33 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 22:57 bug#34765: 26.1; with-temp-buffer should not run buffer-list-update-hook Alexander Miller
2019-03-06 9:39 ` martin rudalics
2019-03-06 11:29 ` Alexander Miller
2019-03-06 14:13 ` martin rudalics
2019-03-06 15:41 ` Eli Zaretskii
2019-03-06 17:57 ` martin rudalics
2019-04-23 9:21 ` martin rudalics
2019-04-23 10:36 ` Eli Zaretskii
2019-04-24 7:27 ` martin rudalics
2019-04-24 11:12 ` Eli Zaretskii
2019-04-24 12:55 ` Stefan Monnier
2019-04-25 8:06 ` martin rudalics
2019-04-25 8:50 ` Eli Zaretskii
2019-04-25 10:31 ` martin rudalics
2019-04-25 10:49 ` Eli Zaretskii
2019-04-26 7:40 ` martin rudalics
2019-04-26 8:09 ` Eli Zaretskii
2019-04-25 13:01 ` Stefan Monnier
2019-04-25 14:34 ` Eli Zaretskii
2019-04-26 7:41 ` martin rudalics
2019-04-26 8:10 ` Eli Zaretskii
2019-04-26 7:41 ` martin rudalics
2019-04-26 8:10 ` Eli Zaretskii
2019-04-26 11:00 ` martin rudalics
2019-04-26 11:26 ` Eli Zaretskii
2019-04-27 8:30 ` martin rudalics
2019-04-26 17:14 ` Basil L. Contovounesios
2019-04-27 8:31 ` martin rudalics
2019-05-20 13:42 ` Basil L. Contovounesios
2019-05-21 7:32 ` martin rudalics
2019-05-21 7:58 ` Basil L. Contovounesios
2019-05-21 10:04 ` martin rudalics
2019-05-22 7:29 ` Eli Zaretskii
2019-05-22 8:32 ` martin rudalics
2019-05-22 10:06 ` Eli Zaretskii
2019-05-23 8:38 ` martin rudalics
2019-05-23 14:37 ` Eli Zaretskii
2019-05-24 8:01 ` martin rudalics
2019-05-22 14:12 ` Stefan Monnier
2019-05-22 15:50 ` Eli Zaretskii
2019-05-22 7:21 ` Eli Zaretskii
2020-08-26 11:06 ` Lars Ingebrigtsen
2020-09-05 7:05 ` Eli Zaretskii
2020-10-07 3:27 ` Lars Ingebrigtsen
2020-10-07 7:58 ` martin rudalics
2020-11-29 21:03 ` Basil L. Contovounesios
2020-11-30 9:05 ` martin rudalics
2020-11-30 18:07 ` Basil L. Contovounesios
2020-11-30 19:01 ` martin rudalics
2020-11-30 20:33 ` Basil L. Contovounesios
2020-12-01 9:34 ` martin rudalics
2020-11-30 19:42 ` Eli Zaretskii
2020-11-30 20:34 ` Basil L. Contovounesios
2020-12-07 22:16 ` Basil L. Contovounesios
2020-12-07 22:37 ` Basil L. Contovounesios
2020-12-08 8:09 ` martin rudalics
2020-12-14 21:03 ` Basil L. Contovounesios
2020-12-15 16:03 ` Eli Zaretskii
2020-12-15 16:24 ` Basil L. Contovounesios
2020-12-18 14:57 ` Basil L. Contovounesios
2020-12-18 15:36 ` Stefan Monnier
2020-12-18 18:49 ` Basil L. Contovounesios
2020-12-19 10:33 ` Eli Zaretskii [this message]
2020-12-19 14:15 ` Basil L. Contovounesios
2020-12-19 16:06 ` Eli Zaretskii
2020-12-19 21:10 ` Basil L. Contovounesios
2020-12-20 15:05 ` Eli Zaretskii
2019-03-07 6:18 ` Alexander Miller
2019-03-07 8:29 ` martin rudalics
2019-03-07 9:44 ` Alexander Miller
2019-03-07 13:46 ` martin rudalics
2020-12-20 17:57 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831rfmultr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=34765@debbugs.gnu.org \
--cc=alexanderm@web.de \
--cc=contovob@tcd.ie \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).