From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50256: thing-at-mouse Date: Sun, 05 Sep 2021 12:24:32 +0300 Message-ID: <831r63v0hb.fsf@gnu.org> References: <87sfys6ubm.fsf@mail.linkov.net> <871r6a8ooe.fsf@gnus.org> <87y28i85xi.fsf@mail.linkov.net> <87k0k1o5ks.fsf@mail.linkov.net> <87ilzk6bsr.fsf@mail.linkov.net> <6dcf3191-dbb3-0c6c-2483-0fc05e9ff6e5@gmx.at> <83lf4gqyn9.fsf@gnu.org> <1a65f234-c1ee-ae95-aa05-2e3d9d1e1002@gmx.at> <8335qoqobm.fsf@gnu.org> <7c9cb0a1-b222-cb06-7e7c-7f17231faca3@gmx.at> <83pmtsp4g1.fsf@gnu.org> <831r67ph8d.fsf@gnu.org> <87tuj3bffb.fsf@gnus.org> <83y28fo1xf.fsf@gnu.org> <191e9cc6-7370-5b7d-7777-716b61e0155d@gmx.at> <83pmtrnydh.fsf@gnu.org> <158a8854-f56a-9aaa-3a14-d108e086a24c@gmx.at> <83k0jznms2.fsf@gnu.org> <87v93j9dfz.fsf@mail.linkov.net> <87y28e4ysv.fsf@mail.linkov.net> <83czpqzupp.fsf@gnu.org> <83v93hyl3l.fsf@gnu.org> <83sfykwyyb.fsf@gnu.org> <087851c3-b3b1-5130-f4b1-50cd42ef83a8@gmx.at> <83ilzgwp2w.fsf@gnu.org> <361bb63a-5e29-9785-0785-6c46f6621223@gmx.at> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3260"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50256@debbugs.gnu.org, larsi@gnus.org, juri@linkov.net To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 05 11:25:26 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mMoOy-0000cW-UB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Sep 2021 11:25:24 +0200 Original-Received: from localhost ([::1]:52708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMoOx-0003eH-BT for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Sep 2021 05:25:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMoOc-0003c8-SH for bug-gnu-emacs@gnu.org; Sun, 05 Sep 2021 05:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37659) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMoOc-0005AF-Kb for bug-gnu-emacs@gnu.org; Sun, 05 Sep 2021 05:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mMoOc-0003AF-Ci for bug-gnu-emacs@gnu.org; Sun, 05 Sep 2021 05:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Sep 2021 09:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50256 X-GNU-PR-Package: emacs Original-Received: via spool by 50256-submit@debbugs.gnu.org id=B50256.163083387612128 (code B ref 50256); Sun, 05 Sep 2021 09:25:02 +0000 Original-Received: (at 50256) by debbugs.gnu.org; 5 Sep 2021 09:24:36 +0000 Original-Received: from localhost ([127.0.0.1]:49205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMoOC-00039Y-87 for submit@debbugs.gnu.org; Sun, 05 Sep 2021 05:24:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMoOB-00039L-0j for 50256@debbugs.gnu.org; Sun, 05 Sep 2021 05:24:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58622) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMoO5-0004f3-0G; Sun, 05 Sep 2021 05:24:29 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4576 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMoO4-0006Zm-JL; Sun, 05 Sep 2021 05:24:28 -0400 In-Reply-To: <361bb63a-5e29-9785-0785-6c46f6621223@gmx.at> (message from martin rudalics on Sun, 5 Sep 2021 09:50:14 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213475 Archived-At: > Cc: juri@linkov.net, 50256@debbugs.gnu.org, larsi@gnus.org > From: martin rudalics > Date: Sun, 5 Sep 2021 09:50:14 +0200 > > >> > That's orthogonal. (And it seems to issue the warning in an unrelated > >> > case, handled by the 'else' clause?) > >> > >> Which case? > > > > This one: > > > >> + else > >> + posint = marker_position (w->pointm); > > You mean when the caller asks for using point in a non-selected window > that does not show the current buffer. Why do you think this case is > unrelated and/or should be handled differently? I see no reason to display a warning in that case. It's completely legitimate; moreover, a non-selected window will almost always display a buffer that is not the current buffer, and annoying warnings in those cases will just ... annoy. > >> Maybe I have not been making myself clear. What I would apply is the > >> attached (modulo any errors it contains): No change in behavior, just a > >> warning in the doc-string and suspicious calls. > > > > That doesn't fix the problem which started this thread, does it? > > Right. We have two ways to fix that problem: > > (1) Fix it in a general way. You don't want to do that because it might > harm calls of that function that silently worked until now. > > (2) Fix it by modifying the calls of `pos-visible-in-window-p'. In that > case the warning should help us find the calls that should be fixed. Once again, the warning is an orthogonal issue. I'm not opposed to displaying a warning in cases where the caller might have intended something else. But let's please first fix the actual issue that started this thread, and that wasn't the lack of warning.