From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50946: Emacs-28: Inadequate coding in hack-elisp-shorthands Date: Fri, 01 Oct 2021 20:53:13 +0300 Message-ID: <831r54einq.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35616"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50946@debbugs.gnu.org To: Alan Mackenzie , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 01 20:06:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWMvF-00096S-Pr for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Oct 2021 20:06:13 +0200 Original-Received: from localhost ([::1]:43348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWMvE-0004le-Oa for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Oct 2021 14:06:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWMjS-0007kz-JP for bug-gnu-emacs@gnu.org; Fri, 01 Oct 2021 13:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45767) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mWMjS-0004vg-9F for bug-gnu-emacs@gnu.org; Fri, 01 Oct 2021 13:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mWMjS-00057Y-8l for bug-gnu-emacs@gnu.org; Fri, 01 Oct 2021 13:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Oct 2021 17:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50946 X-GNU-PR-Package: emacs Original-Received: via spool by 50946-submit@debbugs.gnu.org id=B50946.163311081919653 (code B ref 50946); Fri, 01 Oct 2021 17:54:02 +0000 Original-Received: (at 50946) by debbugs.gnu.org; 1 Oct 2021 17:53:39 +0000 Original-Received: from localhost ([127.0.0.1]:57313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWMj4-00056v-N8 for submit@debbugs.gnu.org; Fri, 01 Oct 2021 13:53:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWMj2-00056i-BN for 50946@debbugs.gnu.org; Fri, 01 Oct 2021 13:53:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48286) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWMiv-0004VE-LH; Fri, 01 Oct 2021 13:53:29 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1177 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWMiv-0001fY-8T; Fri, 01 Oct 2021 13:53:29 -0400 In-Reply-To: (message from Alan Mackenzie on Fri, 1 Oct 2021 17:10:57 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216073 Archived-At: > Date: Fri, 1 Oct 2021 17:10:57 +0000 > From: Alan Mackenzie > > In emacs -Q in the emacs-28 branch, create the following two line file, > foobar.el, and try to load it: > > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > (defvar foo-baz "foobar-baz") > FOOBARELISP-SHORTHANDS: (("foo" . "foobar"))) > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > > This will throw an error, but that isn't important. > > What is important is that the symbol foobar-baz is created by the > elisp-shorthands facility. > > This shouldn't happen since: > 1/- There is no Local Variables section. > 2/- There is no variable elisp-shorthands in that non-existent section. > > The following errors are evident in hack-elisp-shorthands: > 1/- The code doesn't check for a correctly formatted Local Variables > section. > 2/- The code, even if it did check, would only check the last 3000 bytes > in the file. The section can occur anywhere in the last 3000 > CHARACTERS. > 3/- The code doesn't do a case-sensitive search for "elisp-shorthands". > 4/- The code doesn't check for "elisp-shorthands" being a complete > symbol. > 5/- The code doesn't even check that "elisp-shorthands" is in a comment. Thanks. Joćo, could you please look into this?