From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51076: 28.0.60; Null dereference warning with nox build in make_lispy_position Date: Thu, 07 Oct 2021 16:10:41 +0300 Message-ID: <831r4x0ylq.fsf@gnu.org> References: <87wnmp2hkz.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27443"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51076@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 07 15:31:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYTUK-000711-Lk for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Oct 2021 15:31:08 +0200 Original-Received: from localhost ([::1]:57044 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYTUJ-0002kq-GW for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Oct 2021 09:31:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYTAs-0001tH-9S for bug-gnu-emacs@gnu.org; Thu, 07 Oct 2021 09:11:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34829) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYTAr-0001QG-VL for bug-gnu-emacs@gnu.org; Thu, 07 Oct 2021 09:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mYTAr-0001Tw-QJ for bug-gnu-emacs@gnu.org; Thu, 07 Oct 2021 09:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Oct 2021 13:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51076 X-GNU-PR-Package: emacs Original-Received: via spool by 51076-submit@debbugs.gnu.org id=B51076.16336122575684 (code B ref 51076); Thu, 07 Oct 2021 13:11:01 +0000 Original-Received: (at 51076) by debbugs.gnu.org; 7 Oct 2021 13:10:57 +0000 Original-Received: from localhost ([127.0.0.1]:46375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYTAm-0001Tc-OZ for submit@debbugs.gnu.org; Thu, 07 Oct 2021 09:10:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYTAj-0001TO-7T for 51076@debbugs.gnu.org; Thu, 07 Oct 2021 09:10:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36118) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYTAc-0000p6-Sd; Thu, 07 Oct 2021 09:10:47 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1502 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYTAc-0007dv-Ex; Thu, 07 Oct 2021 09:10:46 -0400 In-Reply-To: <87wnmp2hkz.fsf@tcd.ie> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216659 Archived-At: > Date: Thu, 07 Oct 2021 12:35:24 +0100 > From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > In file included from keyboard.c:29: > keyboard.c: In function ‘make_lispy_position’: > frame.h:949:35: warning: null pointer dereference [-Wnull-dereference] > 949 | #define FRAME_TAB_BAR_LINES(f) (f)->tab_bar_lines > | ~~~^~~~~~~~~~~~~~~ > keyboard.c:5134:10: note: in expansion of macro ‘FRAME_TAB_BAR_LINES’ > 5134 | && FRAME_TAB_BAR_LINES (f) > 0 > | ^~~~~~~~~~~~~~~~~~~ > > AFAICT the preceding condition '!FRAME_WINDOW_P (f)' will always be true > in a nox build Yes, but what about a build with X support that displays a TTY frame? I installed a trivial fix.