From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: 51712@debbugs.gnu.org
Subject: bug#51712: 29.0.50; [PATCH] New function `xwidget-webkit-load-html'
Date: Tue, 09 Nov 2021 16:07:59 +0200 [thread overview]
Message-ID: <831r3p5sn4.fsf@gnu.org> (raw)
In-Reply-To: <87y25x5tu9.fsf@yahoo.com> (message from Po Lu on Tue, 09 Nov 2021 21:42:06 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Cc: 51712@debbugs.gnu.org
> Date: Tue, 09 Nov 2021 21:42:06 +0800
>
> >> + text = ENCODE_UTF_8 (text);
> >> + xw = XXWIDGET (xwidget);
> >> +
> >> +#ifdef USE_GTK
> >> + data = SSDATA (text);
> >> + uri = SSDATA (base_uri);
> >> + webview = WEBKIT_WEB_VIEW (xw->widget_osr);
> >> +
> >> + block_input ();
> >> + webkit_web_view_load_html (webview, data, uri);
> >> + unblock_input ();
> >> +#endif
>
> > Hmm... if we only use TEXT and BASE-URI in the GTK build, why do we
> > encode them in the other builds? Isn't that a waste of cycles? IOW,
> > what does this function do if USE_GTK is not defined?
>
> This feature isn't supported on macOS, but it's my hope that someone
> will port it to macOS in short order.
Then I'd suggest not to have it defined on non-GTK builds for now. It
is confusing to have a function that silently does nothing (after
wasting some cycles).
> +@defun xwidget-webkit-load-html xwidget text &optional base-uri
> +Load @var{text} into @var{xwidget}, which should be a WebKit xwidget.
> +It treats @var{text} as HTML markup, which will be rendered by
> +@var{xwidget}.
I'd say that TEXT should be a string. The name itself doesn't
necessarily say so.
> +Optional argument @var{base-uri}, which should be a string, specifies
> +the location of web resources, such as the resource @samp{foo.png} in
> +the HTML tag @samp{<img src="foo.png">}. It defaults to
> +@samp{about:blank}.
Hmm... this is better, but at least I am still in the dark regarding
the need for this optional argument. E.g., what would happen if you
use that tag, but don't specify the URI?
> +*** New function 'xwidget-webkit-load-html'.
> +This function is used to load HTML text into WebKit xwidgets, without
> +having to create a temporary file to store the markup.
This still leaves me wondering why the entry talks about temporary
files.
> +DEFUN ("xwidget-webkit-load-html", Fxwidget_webkit_load_html,
> + Sxwidget_webkit_load_html, 2, 3, 0,
> + doc: /* Make XWIDGET's WebKit widget render text.
^^^^
"text" should be in CAPS.
Thanks.
next prev parent reply other threads:[~2021-11-09 14:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <878rxx8w1i.fsf.ref@yahoo.com>
2021-11-09 10:26 ` bug#51712: 29.0.50; [PATCH] New function `xwidget-webkit-load-html' Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-09 13:21 ` Eli Zaretskii
2021-11-09 13:42 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-09 14:07 ` Eli Zaretskii [this message]
2021-11-09 23:56 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-10 0:02 ` Lars Ingebrigtsen
2021-11-10 0:14 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-10 0:22 ` Lars Ingebrigtsen
2021-11-10 2:44 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-10 5:59 ` Lars Ingebrigtsen
2021-11-10 6:08 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-10 12:50 ` Eli Zaretskii
2021-11-10 13:03 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-10 14:25 ` Eli Zaretskii
2021-11-11 0:31 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-10 4:34 ` Richard Stallman
2021-11-10 4:37 ` Lars Ingebrigtsen
2021-11-11 3:37 ` Richard Stallman
2021-11-10 4:47 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-09 18:26 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831r3p5sn4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=51712@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).