From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54227: 29.0.50; [PATCH] Inconsistencies with Eshell variable interpolation Date: Thu, 03 Mar 2022 19:03:42 +0200 Message-ID: <831qzjj7dd.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14993"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54227@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 03 18:04:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nPosT-0003mJ-My for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Mar 2022 18:04:33 +0100 Original-Received: from localhost ([::1]:34700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPosR-0005ES-5g for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Mar 2022 12:04:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPory-0005Dc-TX for bug-gnu-emacs@gnu.org; Thu, 03 Mar 2022 12:04:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49681) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nPory-0003u5-JH for bug-gnu-emacs@gnu.org; Thu, 03 Mar 2022 12:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nPory-0001v6-1H for bug-gnu-emacs@gnu.org; Thu, 03 Mar 2022 12:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Mar 2022 17:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54227 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54227-submit@debbugs.gnu.org id=B54227.16463270317364 (code B ref 54227); Thu, 03 Mar 2022 17:04:01 +0000 Original-Received: (at 54227) by debbugs.gnu.org; 3 Mar 2022 17:03:51 +0000 Original-Received: from localhost ([127.0.0.1]:43578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPorm-0001uh-Vr for submit@debbugs.gnu.org; Thu, 03 Mar 2022 12:03:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPorl-0001uQ-FK for 54227@debbugs.gnu.org; Thu, 03 Mar 2022 12:03:49 -0500 Original-Received: from [2001:470:142:3::e] (port=53926 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPorg-0003su-6A; Thu, 03 Mar 2022 12:03:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tIqiK8CbSYhQpDXN47zV+G//Q8CTT80jeL1bv/WGAYY=; b=aSS98QzqvvYY CYdUvKzwtiYrT7u5wOheKFv1Zs6uWC2oAA8zVsKdyqBGKbOKaOurhqU6BlWvlCfUDPbSlGZje7+Ev ZFmHLbnopDlNt3rAgM4JXhNPpE70Wzadsb6bAztabKJXsNLPylET00me/L5/mZ+WxUzKZKA5atBBz u6RF8DZ9mNp2mTyD2RHRzopakPyxNcWsyRnSrmHRB86LuPvZT61EGGiaxJ8KZLqSGe3e0rHiIgRiX qfwSVVgFHajXZJHY0doRpuxTfHwG1KIaV9OQb/vOhspFTe8NdTcx7e7x07oH7ntQMf9N4AphXCf4u FX/oTIvjxNBH6vVnGfHXLA==; Original-Received: from [87.69.77.57] (port=1277 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPorf-0001o8-Jy; Thu, 03 Mar 2022 12:03:43 -0500 In-Reply-To: (message from Jim Porter on Wed, 2 Mar 2022 22:35:22 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227963 Archived-At: > From: Jim Porter > Date: Wed, 2 Mar 2022 22:35:22 -0800 > > +(defmacro eshell-with-temp-command (command &rest body) > + "Narrow the buffer to COMMAND and execute the forms in BODY. What does it mean to "narrow the buffer to COMMAND"? Imagine that the user only sees this one line of the doc string -- that actually happens in apropos commands. How can such a user understand what this macro does? > +COMMAND can either be a string, or a cons cell demarcating a > +buffer region. If COMMAND is a string, temporarily insert it > +into the buffer before narrowing. Point will be set to the > +beginning of the narrowed region. After reading this several time and looking at the implementation, I'm beginning to think that COMMAND is not a good name for this argument. > +(defun eshell-parse-inner-double-quote (bound) > + "Parse the inner part of a double quoted string. > +The string to parse starts at point and ends at BOUND. > + > +If Eshell is currently parsing a quoted string and there are any > +backslash-escaped characters, this will return the unescaped > +string, updating point to BOUND. Otherwise, this returns nil and > +leaves point where it was." This seems to just unescape characters in the string? If so, "parse" is not the best name for it, and the first line of the doc string should say "unescape", not "parse". Thanks.