From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54598: 27.2; Bad interraction between modus-theme and hs-minor-mode Date: Thu, 07 Apr 2022 11:27:20 +0300 Message-ID: <831qy9cn87.fsf@gnu.org> References: <87sfr3cp35.fsf@killashandra.ballybran.fr> <87r16kaowt.fsf@gnus.org> <87o81ocv2t.fsf@killashandra.ballybran.fr> <87ee2i735s.fsf@gnus.org> <87ee2iw9p3.fsf@protesilaos.com> <87fsmxc3tv.fsf@killashandra.ballybran.fr> <874k3dlwsa.fsf@protesilaos.com> <83sfqx5oe3.fsf@gnu.org> <87r16fxt56.fsf@killashandra.ballybran.fr> <835ynr48j0.fsf@gnu.org> <87mth3xnsv.fsf@killashandra.ballybran.fr> <834k3a4ukj.fsf@gnu.org> <87wng2xbs4.fsf@killashandra.ballybran.fr> <837d81cuff.fsf@gnu.org> <87h775mlnf.fsf@protesilaos.com> <8335ipcpty.fsf@gnu.org> <87ee29migh.fsf@protesilaos.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14965"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54598@debbugs.gnu.org, larsi@gnus.org, pierre.techoueyres@free.fr To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 07 10:32:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncNZ8-0003fr-Vj for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Apr 2022 10:32:31 +0200 Original-Received: from localhost ([::1]:56684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ncNZ7-0004gR-I8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Apr 2022 04:32:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncNUq-00015p-2d for bug-gnu-emacs@gnu.org; Thu, 07 Apr 2022 04:28:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37619) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ncNUo-0003eW-Kf for bug-gnu-emacs@gnu.org; Thu, 07 Apr 2022 04:28:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ncNUo-0006LY-HM for bug-gnu-emacs@gnu.org; Thu, 07 Apr 2022 04:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Apr 2022 08:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54598 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 54598-submit@debbugs.gnu.org id=B54598.164932004124348 (code B ref 54598); Thu, 07 Apr 2022 08:28:02 +0000 Original-Received: (at 54598) by debbugs.gnu.org; 7 Apr 2022 08:27:21 +0000 Original-Received: from localhost ([127.0.0.1]:59749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ncNU8-0006Kd-MY for submit@debbugs.gnu.org; Thu, 07 Apr 2022 04:27:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ncNU7-0006KP-84 for 54598@debbugs.gnu.org; Thu, 07 Apr 2022 04:27:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45128) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncNU1-0003V5-Mi; Thu, 07 Apr 2022 04:27:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ahw7aFJzN6nMfG2E/dR7Tytk5YkCqtYXJiiz/+wjhZA=; b=GXIGsH0xnVpv k2gZmjeYBjTFwz68V+VkFF8Ej5k8MyyyXKcDOn7uLsRtC03Caiw0ZRTfvkmP+6pTyXJQV0aG31rbx 3mMupJbchgWEkQeo52Sft9xDoX+TMTAIOdHgGa0S0ebTkxy7PSevydTuja6Dqbc94zVz5bVyI0wHQ 1PtRCDWCesu0lGO2T5nljn4GfnAA7qA8fRMarD2UQc4yY/VJAULJxGJRAfmmWCt7TqnOL7NhwJwQa KmsZ7Kieo46QULI2ghX9mQwxrCmCh0Mhis2tricBrNuEa5BwORJaYg40FenpF7cM/21sNTt9RuvQj m3vnVL1r4tTh41nvevuawg==; Original-Received: from [87.69.77.57] (port=1495 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncNU1-0003gs-7y; Thu, 07 Apr 2022 04:27:13 -0400 In-Reply-To: <87ee29migh.fsf@protesilaos.com> (message from Protesilaos Stavrou on Thu, 07 Apr 2022 11:00:14 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229515 Archived-At: > From: Protesilaos Stavrou > Cc: pierre.techoueyres@free.fr, 54598@debbugs.gnu.org, larsi@gnus.org > Date: Thu, 07 Apr 2022 11:00:14 +0300 > > > Please explain which part(s) of those face attributes are supposed to > > produce the thin line, and why do you think that should happen. Maybe > > I'm missing something, but I'm not aware of any face-related feature > > in Emacs that allows us to produce a thin vertical line. That's why > > we use for fill-column-indicator a character whose image is supposed > > to be such a thin vertical line. > > I think the end-result on GNU/Linux is puzzling, given that no face > attribute should explicitly produce this thin line. Still, this result > was discovered experimentally. I think it's a side effect of some peculiarity of the particular implementation. Did you try that with and without Cairo, for example? > With 'emacs -Q' and a fallback/default typeface such as DejaVu Sans Mono > or Hack: > > 1. Create some empty lines in the scratch buffer, such as with 'C-o'. > 2. M-x display-fill-column-indicator-mode > > Notice the thin dashed line. On my system, using DejaVu Sans Mono produces a contiguous vertical line to begin with. In any case, if that doesn't happen with some default font on some system, the solution is either specify a font for this face which does produce a contiguous vertical line, or maybe use an image instead of a character. > 3. (set-face-attribute 'fill-column-indicator nil :height 1 :background "gray50" :foreground "gray50") > > The line is now thin and contiguous. > > Note that the dashed line up to step 2 depends on the ':family' > attribute of the 'default' face. For example, Source Code Pro produces > a contiguous line with the above recipe. Though it too changes to a > dashed style when 'line-spacing' is >= 2. > > When the 'fill-column-indicator' is changed with what is in step 3, even > a higher 'line-spacing' value produces a contiguous line. The background color fills the entire character cell, which is why it isn't affected by the line-spacing. But we have no mechanism that I'm aware of to make the background be 1-pixel thin. > >> (set-face-attribute 'fill-column-indicator nil :inherit 'variable-pitch :height 1 :background "gray50" :foreground "gray50") > > > > Why do you think this should change anything? What do you think the > > inheritance from variable-pitch should do here? > > The assumption is that the proportionate spacing will produce a thinner > character cell, as opposed to the 'default' face which in Pierre's case > is a monospaced font. The width that it takes is determined by the metrics of the U+2502 character in a particular font used by the variable-pitch face on the user's platform. You cannot expect in advance that this width is indeed thin enough, because that character is not designed for these purposes. So I think what you are trying to do is fundamentally unportable, not as long as characters are used for the indicator.